https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 MartinKG <mgansser(a)alice.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://qt-apps.org/content/ | |show.php/QMPlay2?content=15 | |3339 Blocks| |2 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #2 from MartinKG <mgansser(a)alice.de&gt; 2016-03-25 12:12:34 CET --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.03.24-1.fc24.sr... %changelog * Fri Mar 25 2016 Martin Gansser <martinkg(a)fedoraproject.org&gt; - 16.03.24-1 - Update to 16.03.24 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #4 from MartinKG <mgansser(a)alice.de&gt; 2016-05-03 10:58:45 CEST --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.05.02-1.fc24.sr... %changelog * Tue May 03 2016 Martin Gansser <martinkg(a)fedoraproject.org&gt; - 16.05.02-1 - Update to 16.05.02 rpmlint: rpmlint /home/martin/rpmbuild/SRPMS/qmplay2-16.05.02-1.fc24.src.rpm /home/martin/rpmbuild/RPMS/x86_64/qmplay2-16.05.02-1.fc24.x86_64.rpm /home/martin/rpmbuild/RPMS/noarch/qmplay2-kde-integration-16.05.02-1.fc24.noarch.rpm /home/martin/rpmbuild/RPMS/x86_64/qmplay2-devel-16.05.02-1.fc24.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qmplay2-debuginfo-16.05.02-1.fc24.x86_64.rpm qmplay2.src: W: spelling-error Summary(en_US) downloader -> downloaded, down loader, down-loader qmplay2.src: W: spelling-error %description -l en_US ffmpeg -> MPEG qmplay2.src: W: spelling-error %description -l en_US libmodplug qmplay2.x86_64: W: spelling-error Summary(en_US) downloader -> downloaded, down loader, down-loader qmplay2.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG qmplay2.x86_64: W: spelling-error %description -l en_US libmodplug qmplay2.x86_64: W: no-soname /usr/lib64/libqmplay2.so qmplay2.x86_64: W: no-manual-page-for-binary QMPlay2 qmplay2-kde-integration.noarch: W: spelling-error Summary(en_US) subpackage -> sub package, sub-package, package's qmplay2-kde-integration.noarch: W: no-documentation qmplay2-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 11 warnings. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 Rex Dieter <rdieter(a)math.unl.edu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter(a)math.unl.edu --- Comment #6 from Rex Dieter <rdieter(a)math.unl.edu&gt; 2016-05-06 19:28:05 CEST --- Since fedora hasn't supported a kde4 desktop since f21, I'd suggest: * drop -kde-integration subpkg (move the contents to the main pkg) * drop Requires: kde-workspace * move the files to where plasma5/kf5-solid can use them: /usr/share/solid/actions * and co-own /usr/share/solid and /usr/share/solid/actions (with other packages), or add Requires: kf5-filesystem -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #8 from MartinKG <mgansser(a)alice.de&gt; 2016-06-02 16:59:08 CEST --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.06.01-1.fc24.sr... %changelog * Thu Jun 02 2016 Martin Gansser <martinkg(a)fedoraproject.org&gt; - 16.06.01-1 - Update to 16.06.01 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #10 from MartinKG <mgansser(a)alice.de&gt; 2016-06-09 11:13:16 CEST --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.06.01-2.fc24.sr... %changelog * Thu Jun 09 2016 Martin Gansser <martinkg(a)fedoraproject.org&gt; - 16.06.01-2 - Added %%check section for desktop file -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #12 from MartinKG <mgansser(a)alice.de&gt; 2016-08-20 15:24:45 CEST --- new rpm packages: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.08.19-1.fc24.sr... %changelog * Sat Aug 20 2016 Martin Gansser <martinkg(a)fedoraproject.org&gt; - 16.08.19-1 - Update to 16.08.19 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #14 from MartinKG <mgansser(a)alice.de&gt; 2016-08-22 21:04:02 CEST --- (In reply to comment #13) done new rpms: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS /qmplay2-16.08.19-2.fc24.src.rpm %changelog * Mon Aug 22 2016 Martin Gansser <martinkg(a)fedoraproject.org&gt; - 16.08.19-2 - Dropped build script compile_unix - Changed qt5-qtbase-devel to pkgconfig(Qt5) - Removed QT4 BR pkgconfig(QtCore) -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #16 from Vasiliy Glazov <vascom2(a)gmail.com&gt; 2016-08-23 09:08:45 CEST --- 1. Drop Patch0 at all because not using compile_unix script. 2. Change %setup -q -n %{pname}-src-%{version} to %autosetup -n %{pname}-src-%{version} 3. Change %{_qt5_qmake} \ QT_SUFFIX=-qt5 \ QMAKE_CFLAGS="%{optflags}" \ QMAKE_CXXFLAGS="%{optflags}" \ QMAKE_LFLAGS="%{optflags}" to %qmake_qt5 Also, as I see in README.md, for compile in Linux recommended use cmake. May be change build section to %cmake approach and just use %make_install macro in %install section? 4. Change %dir %{_datadir}/%{name}/ %dir %{_datadir}/%{name}/lang to %{_datadir}/%{name} 5. Change %doc %{_datadir}/%{name}/AUTHORS %doc %{_datadir}/%{name}/ChangeLog %doc %{_datadir}/%{name}/README.md %doc %{_datadir}/%{name}/TODO %license %{_datadir}/%{name}/LICENSE to %doc AUTHORS ChangeLog README.md TODO %license LICENSE 6. Change %{_mandir}/man1/%{pname}.1.gz to %{_mandir}/man1/%{pname}.1.* -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #18 from MartinKG <mgansser(a)alice.de&gt; 2016-08-23 19:46:12 CEST --- new rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qmplay2.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qmplay2-16.08.19-3.fc24.sr... %changelog * Tue Aug 23 2016 Martin Gansser <martinkg(a)fedoraproject.org&gt; - 16.08.19-3 - Removed call to gzip manpage file and added %%{_mandir}/man1/%%{pname}.1 to %%files section - Replaced %%{_datadir}/qmplay2 by mcro %%{_pkgdocdir} - Removed installation folder for doc files - Changed if condition for installing system libdir - Used macro %%autosetup - Dropped %%{pname}-debug-info.patch - Used %%{_datadir}/%%{name} for lang files - Switched build commmand to %%cmake - spec file cleanup -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 Vasiliy Glazov <vascom2(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #20 from Vasiliy Glazov <vascom2(a)gmail.com&gt; 2016-08-26 14:52:43 CEST --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v3 or later)", "Unknown or generated". 49 files have unknown license. Detailed output of licensecheck in /home/vascom /review-qmplay2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mime, /usr/share/mime/packages [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/solid/actions(kf5-filesystem, plasma-workspace), /usr/share/solid(kf5-filesystem, plasma-workspace) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in qmplay2 [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in qmplay2 [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qmplay2-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: update-mime-database is invoked in %post and %postun if package stores mime configuration in /usr/share/mime/packages. Note: mimeinfo files in: qmplay2 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qmplay2-16.08.19-3.fc24.x86_64.rpm qmplay2-kde-integration-16.08.19-3.fc24.noarch.rpm qmplay2-devel-16.08.19-3.fc24.x86_64.rpm qmplay2-debuginfo-16.08.19-3.fc24.x86_64.rpm qmplay2-16.08.19-3.fc24.src.rpm qmplay2.x86_64: W: spelling-error Summary(en_US) downloader -> downloaded, down loader, down-loader qmplay2.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG qmplay2.x86_64: W: spelling-error %description -l en_US libmodplug qmplay2-kde-integration.noarch: W: spelling-error Summary(en_US) subpackage -> sub package, sub-package, package's qmplay2-kde-integration.noarch: W: no-documentation qmplay2-devel.x86_64: W: no-documentation qmplay2.src: W: spelling-error Summary(en_US) downloader -> downloaded, down loader, down-loader qmplay2.src: W: spelling-error %description -l en_US ffmpeg -> MPEG qmplay2.src: W: spelling-error %description -l en_US libmodplug 5 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (debuginfo) ------------------- Checking: qmplay2-debuginfo-16.08.19-3.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory qmplay2.x86_64: W: spelling-error Summary(en_US) downloader -> downloaded, down loader, down-loader qmplay2.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG qmplay2.x86_64: W: spelling-error %description -l en_US libmodplug qmplay2-devel.x86_64: W: no-documentation qmplay2-kde-integration.noarch: W: spelling-error Summary(en_US) subpackage -> sub package, sub-package, package's qmplay2-kde-integration.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 6 warnings. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 MartinKG <mgansser(a)alice.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #22 from MartinKG <mgansser(a)alice.de&gt; 2016-08-26 15:39:06 CEST --- (In reply to comment #21) Hi Vasiliy, please change 'Assigned To:' from rpmfusion-package-review(a)rpmfusion.org to vascom2(a)gmail.com and Blocks from 3 to 4 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 MartinKG <mgansser(a)alice.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 --- Comment #23 from MartinKG <mgansser(a)alice.de&gt; 2016-08-26 15:48:47 CEST --- @Vasiliy, Thanks for the review. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.