[Bug 3090] New: Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
3:43 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
Bug #: 3090
Summary: Review request: cmplayer - a Qt-based multimedia
player utilizing the MPV video back-end.
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: thebenj88(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2, 30
Package contains the CMPlayer multimedia player, a GUI for mpv.
rpmlint -i cmplayer-0.8.6-1.fc20.src.rpm
cmplayer.src: W: invalid-url Source0:
https://github.com/xylosper/cmplayer/releases/download/v0.8.6/cmplayer-0....
HTTP Error 403: Forbidden
The value should be a valid, public HTTP, HTTPS, or FTP URL.
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
^^ I'm not sure what's causing this problem, as this URL works both with a web
browser and wget.
rpmlint -i cmplayer-0.8.6-1.fc20.x86_64.rpm
cmplayer.x86_64: W: no-manual-page-for-binary cmplayer
Each executable in standard binary directories should have a man page.
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
^^ Unsure what to do about this.
You'll notice that the spec file refers to 'libchardet-devel' in the
BuildRequires, as I've also packaged libchardet. However, the upstream
developer has included scripts to download and build libchardet statically if
needed. I'm unsure if libchardet should be packaged as well, so I guess this is
up to the reviewer.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:55 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #1 from Ben R <thebenj88(a)gmail.com> 2013-12-29 16:55:13 CET ---
Created attachment 1239
--> https://bugzilla.rpmfusion.org/attachment.cgi?id=1239
libchardet spec file
Attached is the libchardet spec file.
rpmlint -i libchardet-1.0.2-1.fc20.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -i libchardet-1.0.2-1.fc20.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
libchardet-devel.x86_64: W: no-manual-page-for-binary chardet-config
Each executable in standard binary directories should have a man page.
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
^^ Unsure what to do about this.
I'm unable to upload the SRPMs currently due to connection issues, I'll upload
them as soon as I can.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #2 from Ben R <thebenj88(a)gmail.com> 2013-12-29 17:00:18 CET ---
Created attachment 1240
--> https://bugzilla.rpmfusion.org/attachment.cgi?id=1240
CMPlayer spec file
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:42 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
MartinKG <mgansser(a)alice.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mgansser(a)alice.de
--- Comment #3 from MartinKG <mgansser(a)alice.de> 2013-12-29 18:42:32 CET ---
One problem is that RPM Fusion doesn't allow for bundled libraries
(http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries) so
you should open a new ticket in bugzilla for libchardet and set the
new_ticket_no
here.
Depends on : new_ticket_no
please post your rpm package in this form e.g.:
Spec: http://noname.fedorapeople.org/pkgs/revie/package.spec
SRPM: http://noname.fedorapeople.org/pkgs/review/package-0.8.6-1.fc20.src.rpm
%changelog
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:30 a.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
Ben Reedy <thebenj88(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |3092
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:31 a.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #4 from Ben Reedy <thebenj88(a)gmail.com> 2013-12-30 04:31:48 CET ---
SRPM: http://breed808.com/rpmfusion-submission/cmplayer-0.8.6-1.fc20.src.rpm
spec: http://breed808.com/rpmfusion-submission/cmplayer.spec
#3092 has been added as a dependancy
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:49 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
Bug 3090 depends on bug 3092, which changed state.
Bug 3092 Summary: libchardet - Mozilla's Universal Charset Detector C/C++ API
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3092
What |Old Value |New Value
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |WONTFIX
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:57 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mhroncok(a)redhat.com
--- Comment #5 from Miro Hrončok <mhroncok(a)redhat.com> 2014-01-08 21:57:32 CET ---
this needs to unbundle mpv and use the one in repo
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:04 a.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #6 from Ben Reedy <thebenj88(a)gmail.com> 2014-01-09 03:04:37 CET ---
Hello Miro.
I do not think that the upstream developer supports using an external version
of MPV. This is likely a result of their using a fork of MPV[1] that has been
patched to run with CMPlayer.
I can contact the developer for clarification, if you'd like.
[1] https://github.com/xylosper/mpv/compare/mpv-player:master...master
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:47 a.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #7 from Miro Hrončok <mhroncok(a)redhat.com> 2014-01-09 12:47:25 CET ---
We can path our mpv as well than, if it is not breaking anything.
If you mean this seriously, I can look at this closer. We can also discuss this
with upstreams (mpv, cmplayer) and make it work.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:05 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #8 from Miro Hrončok <mhroncok(a)redhat.com> 2014-01-09 13:05:33 CET ---
*patch
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:47 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #9 from Ben Reedy <thebenj88(a)gmail.com> 2014-01-09 13:47:02 CET ---
Response from the CMPlayer developer:
Not possible. CMPlayer is 'linked' against mpv which means
what I need is a library of mpv not an executable and there's no such library indeed.
That's why CMPlayer need whole copy of mpv sources and binaries.
Moreover, some patches cannot just applied to original mpv because they are specialized
for CMPlayer.
Since I have not contributed to mpv so much, I'm saying CMPlayer is a front-end of mpv
with respect for mpv guys, but technically, you'd better think CMPlayer is a fork of
mpv.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:24 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #10 from Miro Hrončok <mhroncok(a)redhat.com> 2014-01-09 14:24:20 CET ---
As I see it in the sources, this bundles a modified version of mpv.
We might call it a fork, but I would say this would need a bundling exception.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:50 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #11 from Ben Reedy <thebenj88(a)gmail.com> 2014-01-09 15:50:18 CET ---
(In reply to comment #10)
As I see it in the sources, this bundles a modified version of mpv.
We might call it a fork, but I would say this would need a bundling exception.
Is there some procedure I need to follow in order to request a bundling
exception?
Will the spec/SRPM need to be altered for this exception?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:18 p.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #12 from Miro Hrončok <mhroncok(a)redhat.com> 2014-01-09 16:18:39 CET ---
Follow https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions
But instead of "You should open up a ticket in the FPC's trac with information
asked for below.", send "Request of bundling exception" to the rpmfusion
mailing list.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:36 a.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #13 from Ben Reedy <thebenj88(a)gmail.com> 2014-01-14 10:36:09 CET ---
Hello Miro,
I emailed the mailing list several days ago about the bundling exception, and
have not heard from anyone. Should I send another email to the mailing list?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:36 a.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
--- Comment #14 from Miro Hrončok <mhroncok(a)redhat.com> 2014-01-14 12:36:24 CET ---
I'd say: Give it a week and then bump the thread.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:32 a.m.
New subject: [Bug 3090] Review request: cmplayer - a Qt-based multimedia player
utilizing the MPV video back-end.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3090
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
2426
days inactive
3768
days old
rpmfusion-developers@lists.rpmfusion.org
17 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla