https://bugzilla.rpmfusion.org/show_bug.cgi?id=2782 Kalev Lember <kalevlember(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|rpmfusion-package-review@rp |kalevlember(a)gmail.com |mfusion.org | --- Comment #1 from Kalev Lember <kalevlember(a)gmail.com&gt; 2013-05-06 01:11:05 CEST --- Perhaps %make_install should define INSTALL by default, instead of having to overriding it in every spec file? It seems to be missing some BuildRequires, I'm getting: checking for SDL - version >= 1.1.6... yes checking SDL/SDL_mixer.h usability... no checking SDL/SDL_mixer.h presence... no checking for SDL/SDL_mixer.h... no configure: error: *** SDL_mixer not found! error: Bad exit status from /var/tmp/rpm-tmp.GU8yg0 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.GU8yg0 (%build) -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2782 --- Comment #3 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-05-09 15:28:46 CEST --- Hi, Thanks for the review! (In reply to comment #2) Yes, my bad, here is a new version with the BuildRequires fixed: SPEC: http://jwrdegoede.danny.cz/abuse.spec SRPM: http://jwrdegoede.danny.cz/abuse-0.8-2.fc19.src.rpm Hmm, I've double checked the install location, .desktop contents and scriptlets and all seems fine. And it does show up in gnome-shell on my F-19 desktop. To double check I've also installed it on my F-18 laptop, which never had abuse before, and the icon shows there too. Maybe your time jumped backward for some reason around the time you were testing this, then gnome-shell may have seen a newer timestamp on /usr/share/icons/hicolor then the one done by the touch from %post, and thus not have updated its cache. Or you've found a gnome-shell bug ? Can you try again? Regards, Hans -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2782 --- Comment #5 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-05-11 10:27:25 CEST --- Hi, (In reply to comment #4) Maybe, I have used icons which were not the exact size of the folder they were installed to before without issues, but maybe that the 255 width, which is not a multiple of 8 is a problem. Anyways, here is a new version which scales the icon to 256x256, if it then still does not work there definitely is something wrong elsewhere. SPEC: http://jwrdegoede.danny.cz/abuse.spec SRPM: http://jwrdegoede.danny.cz/abuse-0.8-3.fc20.src.rpm Yeah, that is why I went with the one from the website, hopefully with the above version everything is ok now. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2782 Kalev Lember <kalevlember(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |4 --- Comment #7 from Kalev Lember <kalevlember(a)gmail.com&gt; 2013-05-16 15:51:31 CEST --- RPMFusion review abuse-0.8-3.fc20.src.rpm 2013-05-16 $ rpmlint abuse \ abuse-debuginfo-0.8-3.fc18.x86_64.rpm \ abuse-0.8-3.fc18.src.rpm abuse.x86_64: W: spelling-error %description -l en_US fullscreen -> full screen, full-screen, firescreen abuse.x86_64: W: invalid-license redistributable abuse.x86_64: E: incorrect-fsf-address /usr/share/doc/abuse-0.8/COPYING.GPL abuse-debuginfo.x86_64: W: invalid-license redistributable abuse.src: W: spelling-error %description -l en_US fullscreen -> full screen, full-screen, firescreen abuse.src: W: invalid-license redistributable 3 packages and 0 specfiles checked; 1 errors, 5 warnings. + OK ! needs attention + rpmlint errors/warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The license isn't suitable for Fedora, but is fine for rpmfusion nonfree + The license field in the spec file matches the actual license + The package contains the license files (COPYING, COPYING.GPL, COPYING.WTFPL) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: ec678b8dc8d00e0382d8c805c6438489 abuse-0.8.tar.gz ec678b8dc8d00e0382d8c805c6438489 Download/abuse-0.8.tar.gz + The package builds fine n/a ExcludeArch bugs filed + BuildRequires look sane + The spec file handles locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages should not contain libtool .la files + Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Looks good! APPROVED -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2782 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.