2:01 p.m.
On Thursday, 25 September 2008 at 15:04, David Timms wrote:
Author: dtimms
Update of /cvs/free/rpms/madplay/devel
In directory se02.es.rpmfusion.net:/tmp/cvs-serv7010
Modified Files:
madplay.spec
Log Message:
Minor spec updates and rebuild madplay for rpmfusion
This commit contains tons of cosmetic (whitespace) changes, which
obscure the real changes. Is it too much to ask to commit pure
cosmetics separately? I'd like a word from other RPMFusion
contributors on this topic.
Regards.
R.
--
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
2:06 p.m.
New subject: rpms/madplay/devel madplay.spec,1.1,1.2
Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 25 September 2008 at 15:04, David Timms wrote:
> Author: dtimms
>
> Update of /cvs/free/rpms/madplay/devel
> In directory se02.es.rpmfusion.net:/tmp/cvs-serv7010
>
> Modified Files:
> madplay.spec
> Log Message:
> Minor spec updates and rebuild madplay for rpmfusion
This commit contains tons of cosmetic (whitespace) changes, which
obscure the real changes. Is it too much to ask to commit pure
cosmetics separately? I'd like a word from other RPMFusion
contributors on this topic.
I'm as guilty as anyone there. That said, makes sense: +1
-- Rex
2:09 p.m.
New subject: rpms/madplay/devel madplay.spec,1.1,1.2
Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 25 September 2008 at 15:04, David Timms wrote:
> Author: dtimms
>
> Update of /cvs/free/rpms/madplay/devel
> In directory se02.es.rpmfusion.net:/tmp/cvs-serv7010
>
> Modified Files:
> madplay.spec
> Log Message:
> Minor spec updates and rebuild madplay for rpmfusion
This commit contains tons of cosmetic (whitespace) changes, which
obscure the real changes. Is it too much to ask to commit pure
cosmetics separately? I'd like a word from other RPMFusion
contributors on this topic.
Yes, please let me know if it's better to not do
such changes at all, or
to commit separately, or as I have done {in one commit both white space
and content changes} for the couple of specs I have imported from dribble.
DaveT.
2:18 p.m.
New subject: rpms/madplay/devel madplay.spec,1.1,1.2
David Timms wrote:
Dominik 'Rathann' Mierzejewski wrote:
...
> This commit contains tons of cosmetic (whitespace) changes,
which
> obscure the real changes. Is it too much to ask to commit pure
> cosmetics separately? I'd like a word from other RPMFusion
> contributors on this topic.
And to help with this particular commit:
diff -udb ../F-9/madplay.spec madplay.spec
--- ../F-9/madplay.spec 2008-08-18 00:25:24.000000000 +1000
+++ madplay.spec 2008-09-25 22:12:02.000000000 +1000
@@ -1,16 +1,16 @@
Name: madplay
Version: 0.15.2b
-Release: 4%{?dist}
+Release: 5%{?dist}
Summary: MPEG audio decoder and player
-Group: System Environment/Libraries
-License: GPL
+Group: Applications/Multimedia
+License: GPLv2+
URL: http://www.underbit.com/products/mad/
Source0:
http://download.sourceforge.net/mad/%{name}-%{version}.tar.gz
Source1: mp3license
Patch0: %{name}-0.15.2b-abxtest-tempfile.patch
Patch1:
http://ftp.debian.org/debian/pool/main/m/madplay/madplay_0.15.2b-4.diff.gz
-BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot: %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
Requires: %{_sbindir}/update-alternatives
BuildRequires: libmad-devel
@@ -35,6 +35,9 @@
%{__patch} -i debian/patches/00_ucs4.diff
sed -i -e 's/[-lz]/[]/' configure.ac ; sed -i -e 's/ -lz / /' configure
touch -r aclocal.m4 configure.ac
+# Recode CREDITS to utf-8
+/usr/bin/iconv -f iso8859-1 -t utf-8 CREDITS > CREDITS.conv \
+ && /bin/mv CREDITS.conv CREDITS
%build
@@ -59,6 +62,7 @@
%{_sbindir}/update-alternatives --install %{_bindir}/mp3-cmdline \
mp3-cmdline %{_bindir}/madplay 30
+
%postun
if [ $1 -eq 0 ] ; then
%{_sbindir}/update-alternatives --remove mp3-cmdline %{_bindir}/madplay
@@ -76,8 +80,14 @@
%changelog
+* Wed Sep 24 2008 David Timms <iinet.net.au@dtimms> 0.15.2b-5
+- import and bump release for rpmfusion.
+- update license to GPLv2+ to meet Fedora guidelines.
+- change Group to Applications/Multimedia
+- convert CREDITS to utf-8
+
* Fri Oct 06 2006 Thorsten Leemhuis <fedora [AT] leemhuis [DOT] info>
0.15.2b-4
- - rebuilt for unwind info generation, broken in gcc-4.1.1-21
+- rebuilt for unwind info generation, broken in gcc-4.1.1-21
* Wed Sep 20 2006 Ville Skyttä <ville.skytta at iki.fi> - 0.15.2b-3
- Rebuild.
bash-3.2$
2:54 p.m.
New subject: rpms/madplay/devel madplay.spec,1.1,1.2
On Thursday, 25 September 2008 at 16:18, David Timms wrote:
David Timms wrote:
>Dominik 'Rathann' Mierzejewski wrote:
...
>>This commit contains tons of cosmetic (whitespace) changes, which
>>obscure the real changes. Is it too much to ask to commit pure
>>cosmetics separately? I'd like a word from other RPMFusion
>>contributors on this topic.
And to help with this particular commit:
diff -udb ../F-9/madplay.spec madplay.spec
Thanks, that's much better, but try -uwbBd...
--- ../F-9/madplay.spec 2008-08-18 00:25:24.000000000 +1000
+++ madplay.spec 2008-09-25 22:12:02.000000000 +1000
@@ -1,16 +1,16 @@
Name: madplay
Version: 0.15.2b
-Release: 4%{?dist}
+Release: 5%{?dist}
Summary: MPEG audio decoder and player
-Group: System Environment/Libraries
-License: GPL
+Group: Applications/Multimedia
+License: GPLv2+
URL: http://www.underbit.com/products/mad/
Source0:
http://download.sourceforge.net/mad/%{name}-%{version}.tar.gz
Source1: mp3license
Patch0: %{name}-0.15.2b-abxtest-tempfile.patch
Patch1:
http://ftp.debian.org/debian/pool/main/m/madplay/madplay_0.15.2b-4.diff.gz
-BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot: %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
Requires: %{_sbindir}/update-alternatives
BuildRequires: libmad-devel
@@ -35,6 +35,9 @@
%{__patch} -i debian/patches/00_ucs4.diff
sed -i -e 's/[-lz]/[]/' configure.ac ; sed -i -e 's/ -lz / /' configure
touch -r aclocal.m4 configure.ac
+# Recode CREDITS to utf-8
+/usr/bin/iconv -f iso8859-1 -t utf-8 CREDITS > CREDITS.conv \
+ && /bin/mv CREDITS.conv CREDITS
%build
@@ -59,6 +62,7 @@
%{_sbindir}/update-alternatives --install %{_bindir}/mp3-cmdline \
mp3-cmdline %{_bindir}/madplay 30
+
%postun
if [ $1 -eq 0 ] ; then
%{_sbindir}/update-alternatives --remove mp3-cmdline %{_bindir}/madplay
... because otherwise you'll miss a stray cosmetic change here. ;)
Regards,
R.
--
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
5703
days inactive
5703
days old
rpmfusion-developers@lists.rpmfusion.org
4 comments
3 participants
participants (3)
-
Agnes Jones -
Dominik 'Rathann' Mierzejewski -
Rex Dieter