2:52 a.m.
I went ahead and tried a build but it failed due to gcc 4.6 being less
tolerant of errors.
Specifically:
error: taking address of temporary
This is beyond my ability to fix. I could add -fpermissive to the
build flags, which in a way would make it equivalent to the F14 build,
but i know that's not the preferred route.
I have posted to the avidemux forum[1] for help so we'll see what
happens. In the meantime, is a build w/ -fpermissive better than no
build at all?
See full error output below[2].
Thanks,
Richard
[1] http://avidemux.org/admForum/viewtopic.php?pid=50390#p50390
[2] Error output:
[ 85%] Building CXX object
avidemux/ADM_UIs/ADM_QT4/src/CMakeFiles/ADM_UIQT4.dir/T_configMenu.cpp.o
cd /builddir/build/BUILD/avidemux_2.5.4/build/avidemux/ADM_UIs/ADM_QT4/src
&& /usr/bin/c++ -DADM_UIQT4_EXPORTS -D_FILE_OFFSET_BITS=64
-D_LARGE_FILES -DHAVE_CONFIG_H -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -O3 -DNDEBUG -fPIC
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux
-I/builddir/build/BUILD/avidemux_2.5.4/build/config
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_core/include
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_coreUI/include
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_coreImage/include
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_coreAudio/include
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_libraries/ADM_utilities
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_libraries/ffmpeg
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_libraries/ffmpeg/libavutil
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_libraries/ffmpeg/libpostproc
-I/builddir/build/BUILD/avidemux_2.5.4/build/avidemux/ADM_UIs/ADM_QT4/src
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/../include
-o CMakeFiles/ADM_UIQT4.dir/T_configMenu.cpp.o -c
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:
In member function 'void
ADM_Qt4Factory::ADM_QconfigMenu::saveAsClicked(bool)':
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:200:31:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:213:69:
error: taking address of temporary [-fpermissive]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:
In member function 'void
ADM_Qt4Factory::ADM_QconfigMenu::comboboxIndexChanged(int)':
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:226:29:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:233:31:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:
In member function 'virtual void
ADM_Qt4Factory::diaElemConfigMenu::updateMe()':
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:319:54:
error: taking address of temporary [-fpermissive]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:
In member function 'virtual void
ADM_Qt4Factory::diaElemConfigMenu::finalize()':
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:359:54:
error: taking address of temporary [-fpermissive]
make[2]: *** [avidemux/ADM_UIs/ADM_QT4/src/CMakeFiles/ADM_UIQT4.dir/T_configMenu.cpp.o]
Error 1
make[2]: Leaving directory `/builddir/build/BUILD/avidemux_2.5.4/build'
make[1]: *** [avidemux/ADM_UIs/ADM_QT4/src/CMakeFiles/ADM_UIQT4.dir/all] Error 2
make[1]: Leaving directory `/builddir/build/BUILD/avidemux_2.5.4/build'
make: *** [all] Error 2
5:53 a.m.
Richard Shaw wrote:
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:213:69:
error: taking address of temporary [-fpermissive]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:319:54:
error: taking address of temporary [-fpermissive]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:359:54:
error: taking address of temporary [-fpermissive]
The error here is that:
bool ADM_QconfigMenu::selectConfiguration(QString *selectFile, ConfigMenuType
configurationType)
takes a QString *. It should really be taking a const QString &. Change
QString *selectFile to const QString &selectFile in that function's prototype
and remove the & from the 3 calls to that function.
That function also compares the result of QComboBox::itemText, which is a
QString, with selectFile. I have no idea how that works. If you change the type
of selectFile to const QString &, it should do the right thing.
Kevin Kofler
12:52 p.m.
On Sun, Apr 17, 2011 at 12:53 AM, Kevin Kofler <kevin.kofler(a)chello.at> wrote:
Richard Shaw wrote:
>
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:213:69:
> error: taking address of temporary [-fpermissive]
>
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:319:54:
> error: taking address of temporary [-fpermissive]
>
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:359:54:
> error: taking address of temporary [-fpermissive]
The error here is that:
bool ADM_QconfigMenu::selectConfiguration(QString *selectFile, ConfigMenuType
configurationType)
takes a QString *. It should really be taking a const QString &. Change
QString *selectFile to const QString &selectFile in that function's prototype
and remove the & from the 3 calls to that function.
I think I did it right but I ran into another error. Here's the lines
as changed:
141: bool ADM_QconfigMenu::selectConfiguration(const QString
&selectFile, ConfigMenuType configurationType)
213: selectConfiguration(QFileInfo(configFileName).completeBaseName(),
CONFIG_MENU_USER);
319: configMenu->selectConfiguration(QString(configName), *configType);
359: configMenu->selectConfiguration(QString(configName), *configType);
Did I make the changes correctly?
I'll paste the new errors at the bottom.
That function also compares the result of QComboBox::itemText, which
is a
QString, with selectFile. I have no idea how that works. If you change the type
of selectFile to const QString &, it should do the right thing.
I somewhat understanding what you're saying but I'm not up on C enough
to quite apply your suggested changes to the code.
Thanks,
Richard
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:141:7:
error: prototype for 'bool
ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(const QString&,
ConfigMenuType)' does not match any in class
'ADM_Qt4Factory::ADM_QconfigMenu'
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.h:49:8:
error: candidate is: bool
ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(QString*,
ConfigMenuType)
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:
In member function 'void
ADM_Qt4Factory::ADM_QconfigMenu::saveAsClicked(bool)':
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:200:31:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:213:87:
error: no matching function for call to
'ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(QString,
ConfigMenuType)'
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:213:87:
note: candidate is:
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.h:49:8:
note: bool ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(QString*,
ConfigMenuType)
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.h:49:8:
note: no known conversion for argument 1 from 'QString' to
'QString*'
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:
In member function 'void
ADM_Qt4Factory::ADM_QconfigMenu::comboboxIndexChanged(int)':
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:226:29:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:233:31:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:
In member function 'virtual void
ADM_Qt4Factory::diaElemConfigMenu::updateMe()':
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:319:67:
error: no matching function for call to
'ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(QString,
ConfigMenuType&)'
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:319:67:
note: candidate is:
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.h:49:8:
note: bool ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(QString*,
ConfigMenuType)
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.h:49:8:
note: no known conversion for argument 1 from 'QString' to
'QString*'
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:
In member function 'virtual void
ADM_Qt4Factory::diaElemConfigMenu::finalize()':
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:359:67:
error: no matching function for call to
'ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(QString,
ConfigMenuType&)'
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:359:67:
note: candidate is:
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.h:49:8:
note: bool ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(QString*,
ConfigMenuType)
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.h:49:8:
note: no known conversion for argument 1 from 'QString' to
'QString*'
1:32 p.m.
On Sun, Apr 17, 2011 at 8:52 AM, Richard Shaw wrote:
On Sun, Apr 17, 2011 at 12:53 AM, Kevin Kofler wrote:
> The error here is that:
> bool ADM_QconfigMenu::selectConfiguration(QString *selectFile, ConfigMenuType
configurationType)
> takes a QString *. It should really be taking a const QString &. Change
> QString *selectFile to const QString &selectFile in that function's
prototype
> and remove the & from the 3 calls to that function.
I think I did it right but I ran into another error. Here's the lines
as changed:
141: bool ADM_QconfigMenu::selectConfiguration(const QString
&selectFile, ConfigMenuType configurationType)
213: selectConfiguration(QFileInfo(configFileName).completeBaseName(),
CONFIG_MENU_USER);
319: configMenu->selectConfiguration(QString(configName), *configType);
359: configMenu->selectConfiguration(QString(configName), *configType);
Did I make the changes correctly?
I'll paste the new errors at the bottom.
> That function also compares the result of QComboBox::itemText, which is a
> QString, with selectFile. I have no idea how that works. If you change the type
> of selectFile to const QString &, it should do the right thing.
I somewhat understanding what you're saying but I'm not up on C enough
to quite apply your suggested changes to the code.
Thanks,
Richard
/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_UIs/ADM_QT4/src/T_configMenu.cpp:141:7:
error: prototype for 'bool
ADM_Qt4Factory::ADM_QconfigMenu::selectConfiguration(const QString&,
ConfigMenuType)' does not match any in class
'ADM_Qt4Factory::ADM_QconfigMenu'
This is C++ rather than C. You also need to update the corresponding
header file, possibly T_configMenu.h
Look for class "ADM_QconfigMenu" in the header file. It will contain
the member prototypes. You need to update the function
selectConfiguration() the same way you updated it in the
implementation file T_configMenu.cpp .
Orcan
1:52 p.m.
Thanks for the help guys but the maintainer got back to me with a
patch that seems to have worked. Now I'm running into a problem with
one of the plugins. I'm not sure if the problem is gcc 4.6 related or
not but as the F14 build succeeded, that's my guess.
[ 89%] Building CXX object
ADM_videoEncoder/ADM_vidEnc_x264/CMakeFiles/ADM_vidEnc_x264.dir/x264Options.cpp.o
cd /builddir/build/BUILD/avidemux_2.5.4/build_plugins/ADM_videoEncoder/ADM_vidEnc_x264
&& /usr/lib64/ccache/c++ -DADM_vidEnc_x264_EXPORTS
-DPLUGIN_CONFIG_DIR=\"x264\" -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -O3 -DNDEBUG -fPIC
-I/builddir/build/BUILD/avidemux_2.5.4
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_libraries/ffmpeg
-I/builddir/build/BUILD/avidemux_2.5.4/build/config
-I/builddir/build/BUILD/avidemux_2.5.4/build_plugins/ADM_videoEncoder/ADM_vidEnc_x264
-I/usr/include/libxml2
-I/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/../common/pluginOptions
-I/builddir/build/BUILD/avidemux_2.5.4/build_plugins/config
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_core/include
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_coreUI/include
-I/builddir/build/BUILD/avidemux_2.5.4/avidemux/ADM_plugin -o
CMakeFiles/ADM_vidEnc_x264.dir/x264Options.cpp.o -c
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp:
In member function 'x264ZoneOptions** x264Options::getZones()':
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp:1014:28:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp:
In member function 'void x264Options::clearZones()':
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp:1022:41:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp:
In member function 'virtual void
x264Options::addOptionsToXml(xmlNodePtr)':
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp:1389:8:
error: 'X264_WEIGHTP_BLIND' was not declared in this scope
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp:
In member function 'void x264Options::parseAnalyseOptions(xmlNode*)':
/builddir/build/BUILD/avidemux_2.5.4/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp:1899:28:
error: 'X264_WEIGHTP_BLIND' was not declared in this scope
Thanks,
Richard
4:01 a.m.
Richard Shaw wrote:
Thanks for the help guys but the maintainer got back to me with a
patch that seems to have worked.
If you mean:
http://fixounet.free.fr/2.6/gcc46_temporary.patch
that patch doesn't look right to me. It fixes the complaints from GCC 4.6
(by copying the temporary to an actual variable), but it doesn't really fix
the underlying issue. There's no reason why selectConfiguration is taking a
QString * rather than just a QString, and the use of that QString * inside
selectConfiguration is invalid, as I explained in my previous mail.
error: 'X264_WEIGHTP_BLIND' was not declared in this scope
That one is due to the new libx264. X264_WEIGHTP_BLIND was renamed to /
replaced by X264_WEIGHTP_SIMPLE.
This is the patch from upstream for this issue:
http://bugs.gentoo.org/attachment.cgi?id=265619&action=diff&conte...
Kevin Kofler
4:02 p.m.
On Sun, Apr 17, 2011 at 11:01 PM, Kevin Kofler <kevin.kofler(a)chello.at> wrote:
Richard Shaw wrote:
> Thanks for the help guys but the maintainer got back to me with a
> patch that seems to have worked.
If you mean:
http://fixounet.free.fr/2.6/gcc46_temporary.patch
that patch doesn't look right to me. It fixes the complaints from GCC 4.6
(by copying the temporary to an actual variable), but it doesn't really fix
the underlying issue. There's no reason why selectConfiguration is taking a
QString * rather than just a QString, and the use of that QString * inside
selectConfiguration is invalid, as I explained in my previous mail.
Well then I'm not sure what to do here. Your fix as it wasn't
sufficient by itself and I don't understand the code (or C++) well
enough to implement Orcan's fix to the header file.
> error: 'X264_WEIGHTP_BLIND' was not declared in this
scope
That one is due to the new libx264. X264_WEIGHTP_BLIND was renamed to /
replaced by X264_WEIGHTP_SIMPLE.
This is the patch from upstream for this issue:
http://bugs.gentoo.org/attachment.cgi?id=265619&action=diff&conte...
This is the one I used. I had to take out one of the entries because
the file was already consistent with the patch.
Thanks,
Richard
4:25 p.m.
On Mon, Apr 18, 2011 at 11:02 AM, Richard Shaw <hobbes1069(a)gmail.com> wrote:
On Sun, Apr 17, 2011 at 11:01 PM, Kevin Kofler
<kevin.kofler(a)chello.at> wrote:
> Richard Shaw wrote:
>> Thanks for the help guys but the maintainer got back to me with a
>> patch that seems to have worked.
>
> If you mean:
> http://fixounet.free.fr/2.6/gcc46_temporary.patch
> that patch doesn't look right to me. It fixes the complaints from GCC 4.6
> (by copying the temporary to an actual variable), but it doesn't really fix
> the underlying issue. There's no reason why selectConfiguration is taking a
> QString * rather than just a QString, and the use of that QString * inside
> selectConfiguration is invalid, as I explained in my previous mail.
To add to this, I found the following Gentoo bug report but if I
understand you correctly, these also just mask the problem from the
compiler instead of fixing them.
http://bugs.gentoo.org/show_bug.cgi?id=364009
Thanks,
Richard
8:32 p.m.
Thanks guys! I looked at what you said again after sleeping on it and
although I don't fully understand it, I got it well enough to apply
the same fix to two other instances of the same problem.
I don't have an F15 install handy to test installing the packages so
I'm gong to cheat and use mock which should at least get me to a rpm
transaction test.
I'll use the same patches and rebuild for F14 to make sure I didn't
break anything obvious.
Thanks again!
Richard
4766
days inactive
4768
days old
rpmfusion-developers@lists.rpmfusion.org
8 comments
3 participants
participants (3)
-
Kevin Kofler -
Orcan Ogetbil -
Richard Shaw