6:01 p.m.
On Sun, 2012-01-01 at 12:42 +0100, Nicolas Chauvet wrote:
Author: kwizart
Update of /cvs/free/rpms/VirtualBox-OSE/devel
In directory se02.es.rpmfusion.net:/tmp/cvs-serv3904/devel
Modified Files:
VirtualBox-OSE.spec
Log Message:
Fix with install -D
Index: VirtualBox-OSE.spec
===================================================================
RCS file: /cvs/free/rpms/VirtualBox-OSE/devel/VirtualBox-OSE.spec,v
retrieving revision 1.84
retrieving revision 1.85
diff -u -r1.84 -r1.85
--- VirtualBox-OSE.spec 1 Jan 2012 10:45:38 -0000 1.84
+++ VirtualBox-OSE.spec 1 Jan 2012 11:41:31 -0000 1.85
@@ -326,7 +326,7 @@
$RPM_BUILD_ROOT%{_sysconfdir}/X11/xorg.conf.d/00-vboxvideo.conf
install -m 0755 -D %{SOURCE10} \
- $RPM_BUILD_ROOT%{_initrddir}/
+ $RPM_BUILD_ROOT%{_initrddir}/vboxweb-service
install -m 0755 -D %{SOURCE10} $RPM_BUILD_ROOT%{_initrddir}/%{SOURCE10}
is more logic for me.
About indentation , I use coding style my tabs have 4 spaces.
:vim set expandtab set softtabstop=4 set ts=4 set sw=4
so all .spec have a mixed with really tabs with tabs expands in spaces.
and I don't know what to do about.
About rename to VirtualBox
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1826
may I just change .spec
Name: VirtualBox-OSE
to
Name: VirtualBox
and keep same cvs locations ?
happy new year!,
--
Sérgio M. B.
8:40 p.m.
New subject: VirtualBox-OSE.spec,1.84,1.85, indentation and rename to VirtualBox
On Sun, 01 Jan 2012 18:01:21 +0000
Sérgio Basto <sergio(a)serjux.com> wrote:
About indentation , I use coding style my tabs have 4 spaces.
:vim set expandtab set softtabstop=4 set ts=4 set sw=4
so all .spec have a mixed with really tabs with tabs expands in
spaces. and I don't know what to do about.
Either use the default of 8 spaces, or convert all tabs to spaces so
that it appears the same regardless of the tab length setting.
--
Jussi Lehtola
Fedora Project Contributor
jussilehtola(a)fedoraproject.org
10:04 p.m.
New subject: VirtualBox-OSE.spec,1.84,1.85, indentation and rename to VirtualBox
On Sun, 2012-01-01 at 22:40 +0200, Jussi Lehtola wrote:
On Sun, 01 Jan 2012 18:01:21 +0000
Sérgio Basto <sergio(a)serjux.com> wrote:
> About indentation , I use coding style my tabs have 4 spaces.
> :vim set expandtab set softtabstop=4 set ts=4 set sw=4
>
> so all .spec have a mixed with really tabs with tabs expands in
> spaces. and I don't know what to do about.
Either use the default of 8 spaces, or convert all tabs to spaces so
that it appears the same regardless of the tab length setting.
I'm trying find fedora code style conventions, after Google it, I got:
https://fedorahosted.org/beakerlib/wiki/CodingStyle
https://fedorahosted.org/sssd/wiki/Contribute
Furthermore, we have adopted the code style and formatting specification
used by the FreeIPA project to describe our C and Python coding
styles.
http://www.freeipa.org/page/Coding_Style#Spaces_and_Indentation
MUST: No tabs all indentation 4 spaces. HIGHLY RECOMMENDED: When
wrapping lines, try to break it:
Tabs or Spaces?
For new projects, spaces-only are strongly recommended over tabs. Most
editors have features that make this easy to do.
Well I just found a easy way to "convert all tabs into spaces"
in vim do :retab reference:
http://vim.wikia.com/wiki/Converting_tabs_to_spaces
So should I retab all .spec ?
Thanks,
--
Sérgio M. B.
10:52 p.m.
New subject: VirtualBox-OSE.spec, 1.84, 1.85, indentation and rename to VirtualBox
2012/1/1 Sérgio Basto <sergio(a)serjux.com>:
On Sun, 2012-01-01 at 22:40 +0200, Jussi Lehtola wrote:
> On Sun, 01 Jan 2012 18:01:21 +0000
> Sérgio Basto <sergio(a)serjux.com> wrote:
> > About indentation , I use coding style my tabs have 4 spaces.
> > :vim set expandtab set softtabstop=4 set ts=4 set sw=4
> >
> > so all .spec have a mixed with really tabs with tabs expands in
> > spaces. and I don't know what to do about.
>
> Either use the default of 8 spaces, or convert all tabs to spaces so
> that it appears the same regardless of the tab length setting.
I'm trying find fedora code style conventions, after Google it, I got:
https://fedorahosted.org/beakerlib/wiki/CodingStyle
https://fedorahosted.org/sssd/wiki/Contribute
Furthermore, we have adopted the code style and formatting specification
used by the FreeIPA project to describe our C and Python coding
styles.
http://www.freeipa.org/page/Coding_Style#Spaces_and_Indentation
MUST: No tabs all indentation 4 spaces. HIGHLY RECOMMENDED: When
wrapping lines, try to break it:
>From http://www.python.org/dev/peps/pep-0008/
Tabs or Spaces?
For new projects, spaces-only are strongly recommended over tabs. Most
editors have features that make this easy to do.
Well I just found a easy way to "convert all tabs into spaces"
in vim do :retab reference:
http://vim.wikia.com/wiki/Converting_tabs_to_spaces
So should I retab all .spec ?
Talking about spec files both are legal according to
rpmlint, but if
you choose one, it needs to stay the same for entire spec file.
Now you are working with others, and changing the indent back and
forth isn't fair.
when one indent has been chosen it's better to stay with it.
I'm more interested by having the changelog diff betweek devel and
F-16 sorted out.
Nicolas (kwizart)
11:16 p.m.
New subject: VirtualBox-OSE.spec, 1.84, 1.85, indentation and rename to VirtualBox
On Sun, 2012-01-01 at 23:52 +0100, Nicolas Chauvet wrote:
I'm more interested by having the changelog diff between devel
and
F-16 sorted out.
diff devel/ F-16/ -u
I had done more changelogs on devel, because I do and undo some
patches , when I copy from devel to F-16 , I wrote changelog again , If
I had done one do and undo in devel, will not appear on F-16 changelog .
Also sometimes, I try improve a little the text , but is basically the
same thing.
Have we any convention on this matter ? and conventions about release
numbers ?
I try, that release on F-15 be minor than F-16 and F-16 be minor of
devel, to yum update works after upgrades.
Example:
4.1.6-1.fc15
4.1.6-4.fc16
and
VirtualBox-OSE-4.1.8-1.fc16
VirtualBox-OSE-4.1.8-3.fc17
Thanks,
--
Sérgio M. B.
8:09 a.m.
New subject: VirtualBox-OSE.spec,1.84,1.85, indentation and rename to VirtualBox
Quoting "Sérgio Basto" <sergio(a)serjux.com>:
On Sun, 2012-01-01 at 22:40 +0200, Jussi Lehtola wrote:
> Either use the default of 8 spaces, or convert all tabs to spaces so
> that it appears the same regardless of the tab length setting.
I'm trying find fedora code style conventions, after Google it, I got:
https://fedorahosted.org/beakerlib/wiki/CodingStyle
https://fedorahosted.org/sssd/wiki/Contribute
Furthermore, we have adopted the code style and formatting specification
used by the FreeIPA project to describe our C and Python coding
styles.
Note: these are not Fedora standards.
Fedora doesn't have a standard for spec file tabbing. The issue has been
discussed before on fedora-devel, and the agreement was pretty much to use
spaces since that way the spec looks the same regardless of the tab width.
--
Jussi Lehtola
Fedora Project Contributor
jussilehtola(a)fedoraproject.org
4509
days inactive
4510
days old
rpmfusion-developers@lists.rpmfusion.org
5 comments
3 participants
participants (3)
-
Nicolas Chauvet -
Susi Lehtola -
Sérgio Basto