[Bug 3953] New: Review request: dwarffortress - A single-player procedurally generated fantasy game
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3953
Bug #: 3953
Summary: Review request: dwarffortress - A single-player
procedurally generated fantasy game
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: rosser.bjr(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Source URL:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/rpmfusion/dwarffortress...
SRPM URL:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/rpmfusion/dwarffortress...
Description: Dwarf Fortress is a single-player fantasy game. You can control a
dwarven outpost or an adventurer in a randomly generated, persistent world.
Although Dwarf Fortress is still in a work in progress, many features have
already been implemented.
Dwarf Fortress is free to redistribute, but is not open source.
Why rpmfusion(-nonfree): Dwarf Fortress is not open source, so cannot be
included in Fedora. However, there is an open source component (the graphics
library) that should be compiled and linked against the system libraries
(rather than the bundled ones included in the download).
Other comments:
This work is mostly based on the work done for Arch Linux (see
https://www.archlinux.org/packages/multilib/x86_64/dwarffortress/)
As I mentioned on the list, this is my first rpmfusion package, but I *am* a
sponsored Fedora packager.
Since then, I've updated the spec for the newest upstream release of DF and
also broken up the archive; rather than place it in /opt, I've opted to put the
"binaries" into %_libexecdir and the data into %_datadir. The "dwarffortress"
script originally written for Arch Linux has been adjusted; it creates a DF
installation in ~/.dwarffortress from these locations and then executes out of
there, using symlinks.
Another thing to please note is that the package only builds on i686 so I have
made use of the "ExclusiveArch" tag.
rpmlint output:
[bjr@irune SPECS]$ rpmlint ../RPMS/i686/dwarffortress-0.42.05-3.fc22.i686.rpm
dwarffortress.i686: W: spelling-error Summary(en_US) procedurally -> procedural
dwarffortress.i686: W: spelling-error %description -l en_US dwarven -> warden
dwarffortress.i686: W: invalid-license Dwarf Fortress
dwarffortress.i686: E: binary-or-shlib-defines-rpath
/usr/libexec/dwarffortress/Dwarf_Fortress ['$ORIGIN']
dwarffortress.i686: W: unstripped-binary-or-object
/usr/libexec/dwarffortress/libgraphics.so
dwarffortress.i686: W: no-manual-page-for-binary dwarffortress
[bjr@irune SPECS]$ rpmlint
/var/lib/mock/fedora-22-i386/result/dwarffortress-0.42.05-3.fc22.src.rpm
dwarffortress.src: W: spelling-error Summary(en_US) procedurally -> procedural
dwarffortress.src: W: spelling-error %description -l en_US dwarven -> warden
dwarffortress.src: W: invalid-license Dwarf Fortress
dwarffortress.src:45: W: macro-in-comment %{buildroot}
dwarffortress.src:77: W: macro-in-comment %{_libdir}
dwarffortress.src:77: W: macro-in-comment %{buildroot}
dwarffortress.src:77: W: macro-in-comment %{optdir}
Of these, I think the main objections that aren't spelling errors or comments
are:
-The rpath/unstripped binary error/warning. Dwarf_Fortress is the actual
"binary" that is closed-source; I don't think we can do anything about this.
-The license. Is there a specific way I should reference a custom license? The
Dwarf Fortress license text is as follows:
"Copyright (c) 2002-2012. All rights are retained by Tarn Adams, save the
following: you may redistribute the binary and accompanying files, unmodified,
provided you do so free of charge. If you'd like to distribute a modified
version of the game or portion of the archive and are worried about copyright
infringement, please contact Tarn Adams at toadyone(a)bay12games.com.
This software is still in development, and this means that there are going to
be problems, including serious problems that, however unlikely, might damage
your system or the information stored on it. Please be aware of this before
playing."
For testing purposes a RPM repository is available here:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/ (along with the public GPG
key). I've tested these packages on both Fedora 22 and Fedora 23.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7 years, 2 months
[Bug 3805] New: Review request: cannonball - An Enhanced OutRun Engine
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3805
Bug #: 3805
Summary: Review request: cannonball - An Enhanced OutRun Engine
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: musuruan(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
https://dl.dropboxusercontent.com/u/12575912/reviews/cannonball.spec
https://dl.dropboxusercontent.com/u/12575912/reviews/cannonball-0.3-1.fc2...
Description:
Cannonball is a program which allows you to play an enhanced version of
Yu Suzuki's seminal arcade racer, OutRun, on a variety of systems:
- 60 fps gameplay (smoother than the original game)
- True widescreen mode (extend the play area by 25%)
- High Resolution mode (improves sprite scaling)
- Time Trial Mode
- Cheats
- Customisable Music
- High Score Saving
- Western, Japanese & prototype track support
- Analog & Digital controllers supported
- Force Feedback / Haptic support (Windows only)
- Fixes bugs present in the original game
Why not in Fedora:
Emulators are not allowed in Fedora
Rpmlint output:
$ rpmlint /home/andrea/rpmbuild/SRPMS/cannonball-0.3-1.fc21.src.rpm
cannonball.src: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
cannonball.src: W: spelling-error %description -l en_US widescreen -> wide
screen, wide-screen, windscreen
cannonball.src: W: invalid-license Custom
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ rpmlint /home/andrea/rpmbuild/RPMS/x86_64/cannonball-0.3-1.fc21.x86_64.rpm
cannonball.x86_64: W: spelling-error %description -l en_US gameplay -> game
play, game-play, nameplate
cannonball.x86_64: W: spelling-error %description -l en_US widescreen -> wide
screen, wide-screen, windscreen
cannonball.x86_64: W: invalid-license Custom
cannonball.x86_64: W: no-manual-page-for-binary cannonball
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpmlint
/home/andrea/rpmbuild/RPMS/x86_64/cannonball-debuginfo-0.3-1.fc21.x86_64.rpm
cannonball-debuginfo.x86_64: W: invalid-license Custom
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
AFAIK spelling is correct and the license is fine too since we are in RPM
Fusion.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7 years, 3 months
[Bug 4393] New: Review Request: zoneminder - A camera monitoring and
analysis tool
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393
Bug ID: 4393
Summary: Review Request: zoneminder - A camera monitoring and
analysis tool
Product: Package Reviews
Version: Current
Hardware: x86_64
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-review(a)rpmfusion.org
Reporter: zonexpertconsulting(a)outlook.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2, 30
%description
ZoneMinder is a set of applications which is intended to provide a complete
solution allowing you to capture, analyze, record and monitor any cameras you
have attached to a Linux based machine. It is designed to run on kernels which
support the Video For Linux (V4L) interface and has been tested with cameras
attached to BTTV cards, various USB cameras and IP network cameras. It is
designed to support as many cameras as you can attach to your computer without
too much degradation of performance.
A little background. Zoneminder currently lives in the Fedora 25 repo and the
repo at zmrepo.zoneminder.com, which I am the maintainer of. In conversation
with the Fedora team, we agree that, due to zoneminder's ffmpeg dependencies,
it will be removed from the Fedora repo moving forward. In my opinion, the best
place for the zoneminder package to live is at RPMFusion, because some of
zoneminder's dependencies already exist here.
This is my first RPMFusion package. Note that I am also part of the upstream
zoneminder development team, and I do have a member of the Fedora packaging
team willing to support/sponsor me. It does look like I still need an RPMFusion
sponsor though.
Please note that zoneminder will currently build against the RPMFusion repo,
but it will not install, due to several missing dependencies. I am in the
process of learning how to get the following dependencies into Fedora and EPEL,
or failing that, RPMFusion:
cambozola
perl-Class-Std-Fast
perl-IO-Socket-Multicast
perl-SOAP-WSDL
perl-X10-ActiveHome
perl-Astro-SunTime
All of these packages currently exist in zmrepo.
zoneminder rpm specfile:
https://gist.github.com/knnniggett/cf2e4e2169ed8d4147b6367d6a60a843
The following SRPM will build on EL6 (i386, x86_64), EL7 (x86_64), and Fedora
(i386,x86_64,armhfp):
https://zmrepo.zoneminder.com/f/testing/25/SRPMS/zoneminder-1.30.1-1.fc25...
Here is a complete rpmlint output:
https://gist.github.com/knnniggett/e944c47a5cfdfe71cf68d3ac2366afe2
What follows is a line-by-line response to what rpmlint found:
invalid-url Source0: ZoneMinder-1.30.1.tar.gz
Because zoneminder uses git submodules, the easiest thing for me to do is
create the tarball from my own local git repo. Fedora packaging guidelines
state this method is acceptable. However, please advise if a different method
would be preferred.
non-readable /etc/zm/zm.conf 640
This config file contains the mysql database login credentials. Hence the
reason for the 640 permissions. This is by design.
dangling-relative-symlink /usr/share/zoneminder/www/cambozola.jar
../../java/cambozola.jar
Zoneminder expects the cambozola.jar file to exist within zoneminder's web
root. Hence the purpose of the symlink.
explicit-lib-dependency libcurl
libcurl is one of the methods zoneminder uses to receive a stream from a
camera. If memory serves, rpmbuild does not autodetect this.
explicit-lib-dependency libjpeg-turbo
This is to ensure we have the turbo jpeg library rather than the legacy jpeg
library. Older el6 distros can have both so we want to make sure the turbo
library is installed.
no-manual-page-for-binary zmXXXXX.xx
These entries are incorrect. Zoneminder uses pod2man to dynamically create man
pages for its executables.
all the rest items under zoneminder's api folder
Zoneminder uses cakephp 2.8 and these entries are all part of that framework. I
am hesitant to do anything about these entries because they are from a
different project. Please advise.
Whew! Lots of information here, but I still feel like I am forgetting
something.
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
https://bugzilla.rpmfusion.org/show_bug.cgi?id=30
[Bug 30] Tracker : Sponsorship Request
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
7 years, 4 months