https://bugzilla.rpmfusion.org/show_bug.cgi?id=2472
--- Comment #10 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2012-10-28 14:42:32 CET
---
(In reply to comment #6)
Here is the review:
Thanks for the review!
Issues:
1. COPYING.LIB is not included in %doc
2. Compile output is not verbose. I cannot check the CFLAGS used.
Both are fixed in my next version.
(In reply to comment #7)
The description in the RPM should probably be updated, this plugin
depends on
libav and not ffmpeg so saying it provided provides FFmpeg-based plugins is not
correct. So just like we don't refer to Inkscape as Sodipodi we shouldn't refer
to libav as ffmpeg.
Fixed in my next version as well.
(In reply to comment #9)
Added COPYING.LIB to %doc. Run ldconfig in %post(un). Run make with
V=1 to
provide verbose compile command output including CFLAGS. Updated to new
upstream release 1.0.2:
Running ldconfig is wrong / not needed as these are plugins not libraries.
Other then that
out specfiles are pretty much in sync :)
Here is my latest version:
http://jwrdegoede.danny.cz/gstreamer1-libav.spec
http://jwrdegoede.danny.cz/gstreamer1-libav-1.0.2-1.fc19.src.rpm
And here is the changelog:
* Sun Oct 28 2012 Hans de Goede <j.w.r.degoede(a)gmail.com> - 1.0.2-1
- Rebase to 1.0.2
- Included libav copy updated to 0.8.4
- Change the license to LGPLv2+, as the GPL only postproc plugin is no longer
included
- Replace references to ffmpeg with libav (rf#2472)
- Add COPYING.LIB to %%doc (rf#2472)
- Run make with V=1 (rf#2472)
--
Configure bugmail:
https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.