Jeremy Newton <alexjnewt(a)hotmail.com> changed:
What |Removed |Added
--- Comment #3 from Jeremy Newton <alexjnewt(a)hotmail.com> 2012-03-10 22:39:54 CET
A bunch of notes, I can do a full review later:
-the Love Review Request has been moved to Fedora (but you probably know that
-Your desktop file should to be installed via proper methods (ie.
this allows you to have feedback for what maybe wrong with your desktop file,
if an issue exists. For example I can tell that one of the fields in your
desktop file should be removed. (see my SPRM below)
-You missing %post, %postun and %posttrans sections, which are required for
desktop files with icons: (you can also see my SPRM below)
-I would suggest using a secondary source rather than the echo commands, as it
may make the spec a little less legible/clean. Furthermore, a license probably
file should be included (see my SPRM below)
-unzip is not required, as described in the fedora guidelines:
-I would suggest to make an attachment for your spec file or upload it
somewhere instead of posting it directly in the comments for proceeding
revisions. I would suggest dropbox, as an account is free and the public folder
allows you to copy the "public link".
-You can silence the RPMLint warning by making an empty %build section (see my
-you seem to have beat me to packaging this, and maybe if you take a look at my
SPRM, as it could help:
By the way, kudos for the idea of getting the logo from the love file, it never
occurred to me to do that.
-If this is your first package, I would guess that you have not yet been
sponsored. If you're not sponsored in either RPM Fusion or Fedora, please block
-Man pages are not vital for getting your package accepted, but it is suggested
to look into making one.
-To my knowledge %defattr(-, root, root) shouldn't be required, but to be
honest I've never used it before.
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.