https://bugzilla.rpmfusion.org/show_bug.cgi?id=2711 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |3 --- Comment #2 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-04-07 15:27:49 CEST --- Good: - rpmlint checks return: assaultcube.src: W: invalid-license Expat assaultcube.src: W: invalid-license Redistributable assaultcube.src: W: strange-permission AssaultCube-startscript.sh 0755L assaultcube.src: W: strange-permission AssaultCube-server.sh 0755L assaultcube.x86_64: W: invalid-license Expat assaultcube.x86_64: W: invalid-license Redistributable These can be ignored - package meets naming guidelines - package meets packaging guidelines - license (Expat + Redistributable) OK - spec file legible, in am. english - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime Needs work: assaultcube.src: W: invalid-url Source1: http://transact.dl.sourceforge.net/sourceforge/actiongame/AssaultCube_v1.... <urlopen error [Errno -2] Name or service not known> assaultcube.src: W: invalid-url Source0: http://transact.dl.sourceforge.net/sourceforge/actiongame/AssaultCube_v1.... <urlopen error [Errno -2] Name or service not known> assaultcube.x86_64: W: spurious-executable-perm /usr/share/doc/assaultcube-1.1.0.4/docs/colouredtext.txt assaultcube.x86_64: W: file-not-utf8 /usr/share/doc/assaultcube-1.1.0.4/docs/package_copyrights.txt assaultcube.x86_64: E: non-standard-dir-perm /usr/share/assaultcube/packages/maps 01757L assaultcube.x86_64: W: file-not-in-%lang /usr/share/assaultcube/packages/locale/de/LC_MESSAGES/AC.mo assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/include/enet/unix.h assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/host.c assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/protocol.c assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/include/enet/list.h assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/unix.c assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/packet.c assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/list.c assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/include/enet/protocol.h assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/include/enet/enet.h assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/include/enet/types.h assaultcube-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/1.1.0.4/source/enet/peer.c Please fix all these: - do chmod -x on the source files in %prep - See: http://pkgs.fedoraproject.org/cgit/usbview.git/tree/usbview.spec for an example howto fix the utf8 warning - Use find_lang for the translations (or mark them manually if there are only a few) - chmod the spurious dir in %prep to something reasonable - desktop files not properly installed. The desktop files should be "generated" in the build dir and then installed with desktop-file-install, related to this the desktop files should not contain the Version field, this gets set by desktop-file-install - RPM_OPT_FLAGS is not honored. .c files are compiled without any flags, .cpp files are compiled with "-O3 -fomit-frame-pointer", both are wrong. Be sure to keep the -fsigned-char. This may be due to the use of %optflags, which should be %rpmoptflags or $RPM_OPT_FLAGS under Fedora -drop the %make_install, it does not do anything other then copying the binaries from source/src/ac_client to bin_unix/native_client and source/src/ac_server to bin_unix/native_server, instead just install the binaries directly from source/src/ac_* -instead of "cd source/src .... cd ../.." use "pushd source/src .... popd" -Source urls are wrong, see: http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net -The data files license as described here: http://packages.debian.org/changelogs/pool/non-free/a/assaultcube-data/as... Seems to be missing from %doc -Drop the bogus software downscaled images, desktop environments can do scaling of icons just fine, multiple size icons are useful when they are hand-drawn, software scaled versions are useless. You can then also drop the ImgaeMagick BuildRequires. Not checked due to needs work items: - source matches upstream -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2711 --- Comment #3 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-04-08 12:18:05 CEST --- On the review swap, it turns out that fbg has turned into fbg2, but without proper Obsoletes / Provides, rather then re-introducing an old stale version of fbg, I've closed the re-review request for it. I will of course still finish this review. If you could review a future package of mine that would be much appreciated. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2711 --- Comment #5 from Rahul Sundaram <metherid(a)gmail.com&gt; 2013-04-20 10:06:48 CEST --- So, I fixed most of the issues highlighted. TODO: I didn't get the package to compile using rpmoptflags and I am unsure how to fix that. Help appreciated I don't think a change to use find_lang is necessary since there appears to only one locale file but do take a look Also, the copyright license doc is not included in the package since it is a summary of the license review created by Debian. It is helpful as a pointer that this package is redistributable but that is the extend of its usefulness in RPM Fusion. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2711 --- Comment #7 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-05-04 12:10:18 CEST --- Created attachment 1091 --> https://bugzilla.rpmfusion.org/attachment.cgi?id=1091 New version of spec fixing optflags support Hi, Here is a new version of the spec file fixing the optflags support, as well as some other issues (see changelog). Note this also adds the use of an extra patch, I will attach that next. Regards, Hans -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2711 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 |4 --- Comment #9 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-05-04 12:12:02 CEST --- Note: I've only compile tested my version, you should probably run-test it a bit. With my own fixes for optflags and buildin enet usage, I no longer see any issues, so: APPROVED! -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2711 --- Comment #11 from Rahul Sundaram <metherid(a)gmail.com&gt; 2013-05-15 10:10:20 CEST --- can any of the rpmfusion admins let me know if I need to do anything more? I have waited a while and I am not sure what I should be doing next. This is my first rpmfusion package. thanks -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2711 Rahul Sundaram <metherid(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.