[Bug 5122] New: Review Request: omxplayer - Raspberry Pi command
line OMX player
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5122
Bug ID: 5122
Summary: Review Request: omxplayer - Raspberry Pi command line
OMX player
Product: Package Reviews
Version: Current
Hardware: arm
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-review(a)rpmfusion.org
Reporter: zonexpertconsulting(a)outlook.com
CC: rpmfusion-package-review(a)rpmfusion.org
namespace: rpi
FAS account: kni
WHY NOT FEDORA?
---------------
This package needs ffmpeg, in addition to raspberrypi-vc.
SPEC URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/omxplayer...
SRPM URL:
http://koji.rpmfusion.org/kojifiles/work/tasks/3453/283453/omxplayer-2018...
DESCRIPTION
-----------
OMXPlayer is a video player specifically made for the Raspberry Pi's GPU.
It relies on the OpenMAX hardware acceleration API, which is the Broadcom's
VideoCore officially supported API for GPU video/audio processing.
NOTES
-----
- I have removed the bundled ffmpeg requirement. The package builds against the
ffmpeg package in the rpi namespace.
- This package has no cmake or autotools. Just a Makefile. The Makefile must be
altered for compatibility. My preference was to use sed to accomplish this,
rather than patch files. I found it easier to manipulate the compiler flags
this way as I was testing.
- This is still a work in progress. I have not yet run the player, but I do
want to start the peer review process to verify my work.
PROVIDES
---------
$ rpm -q --provides omxplayer-20181014-3.7f3faf6.fc29.armv7hl.rpm
omxplayer = 20181014-3.7f3faf6.fc29
omxplayer(armv7hl-32) = 20181014-3.7f3faf6.fc29
REQUIRES
--------
$ rpm -q --requires omxplayer-20181014-3.7f3faf6.fc29.armv7hl.rpm
/usr/bin/bash
fbset
gnu-free-sans-fonts
ld-linux-armhf.so.3
ld-linux-armhf.so.3(GLIBC_2.4)
libasound.so.2
libasound.so.2(ALSA_0.9)
libasound.so.2(ALSA_0.9.0rc4)
libavcodec.so.58
libavcodec.so.58(LIBAVCODEC_58)
libavformat.so.58
libavformat.so.58(LIBAVFORMAT_58)
libavutil.so.56
libavutil.so.56(LIBAVUTIL_56)
libbcm_host.so
libbrcmEGL.so
libbrcmGLESv2.so
libc.so.6
libc.so.6(GLIBC_2.28)
libc.so.6(GLIBC_2.4)
libc.so.6(GLIBC_2.8)
libdbus-1.so.3
libdbus-1.so.3(LIBDBUS_1_3)
libfreetype.so.6
libgcc_s.so.1
libgcc_s.so.1(GCC_3.5)
libm.so.6
libm.so.6(GLIBC_2.27)
libm.so.6(GLIBC_2.4)
libopenmaxil.so
libpcre.so.1
libpthread.so.0
libpthread.so.0(GLIBC_2.4)
librt.so.1
librt.so.1(GLIBC_2.4)
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(CXXABI_1.3.8)
libstdc++.so.6(CXXABI_ARM_1.3.3)
libstdc++.so.6(GLIBCXX_3.4)
libstdc++.so.6(GLIBCXX_3.4.11)
libstdc++.so.6(GLIBCXX_3.4.15)
libstdc++.so.6(GLIBCXX_3.4.18)
libstdc++.so.6(GLIBCXX_3.4.19)
libstdc++.so.6(GLIBCXX_3.4.20)
libstdc++.so.6(GLIBCXX_3.4.21)
libswresample.so.3
libswresample.so.3(LIBSWRESAMPLE_3)
libswscale.so.5
libvchiq_arm.so
libvcos.so
libz.so.1
omxplayer-libs(armv7hl-32) = 20181014-3.7f3faf6.fc29
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)
RPMLINT
--------
>omxplayer.src:80: W: macro-in-comment %{commit_date}
>omxplayer.src:81: W: macro-in-comment %{commit_short}
>omxplayer.src:83: W: macro-in-comment %{url}
This is a false positive caused by the way the specfile generates version.h
>omxplayer.armv7hl: E: incorrect-fsf-address /usr/share/licenses/omxplayer/COPYING
PR sent upstream:
https://github.com/popcornmix/omxplayer/pull/670
>omxplayer.armv7hl: W: spurious-executable-perm /usr/share/man/man1/omxplayer.1.gz
I'm not how this mangpage ended up with execute bit set. Can look into this if
asked to.
>omxplayer.armv7hl: W: no-manual-page-for-binary omxplayer.bin
False positve. omxplayer is a wrapper for omxplayer.bin. Thus, omxplayer.1 is
the man page for this binary.
>omxplayer-desktop.armv7hl: E: explicit-lib-dependency libnotify
The desktop subpackage has libnotify as an installation requirement. I left it
in due to historical reasons. I am not sure why it is there, but I can look
into it if asked.
>omxplayer-desktop.armv7hl: W: no-documentation
This subpackage is nothing but a .desktop file. It doesn't need documentation.
>omxplayer-desktop.armv7hl: W: desktopfile-without-binary /usr/share/applications/omxplayer.desktop lxterminal
The binary is in the base package.
>3 packages and 0 specfiles checked; 2 errors, 7 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
3 years, 5 months
[Bug 4027] New: fs-uae - Amiga emulator with on-screen GUI and online play support
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4027
Bug #: 4027
Summary: fs-uae - Amiga emulator with on-screen GUI and online
play support
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: musuruan(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Spec file:
https://dl.dropboxusercontent.com/u/12575912/reviews/fs-uae.spec
Source RPM:
https://dl.dropboxusercontent.com/u/12575912/reviews/fs-uae-2.6.2-1.fc23....
Description:
FS-UAE is an Amiga emulator for Windows, Linux and Mac OS X
based on UAE/WinUAE, with a focus on emulating games.
Features include emulation of Amiga 500, 1200, 4000, CD32
and CDTV, perfectly smooth scrolling on 50Hz displays, support
for floppy images in ADF and IPF formats, CD-ROM images in ISO
or BIN/CUE format, mounting folders on your computer as Amiga
hard drives, support for Picasso 96 drivers for high-color and
high-resolution Workbench displays, and more.
A unique feature is support for cross-platform online play. You
can now play Amiga games against (or with) friends over the
Internet.
The emulator uses the latest Amiga emulation code from the
WinUAE project and requires a moderately fast computer with
accelerated graphics (OpenGL) to work. A game pad or joystick is
recommended, but not required (FS-UAE can emulate a joystick
using the cursor keys and right ctrl/alt keys).
Why is this package not eligible to be included in Fedora?
Because it depends on packages in RPM Fusion.
rpmlint output:
[andrea@panoramix SPECS]$ rpmlint
/home/andrea/rpmbuild/SRPMS/fs-uae-2.6.2-1.fc23.src.rpm
fs-uae.src: W: spelling-error %description -l en_US ctrl -> ctr, curl, ctr l
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[andrea@panoramix SPECS]$ rpmlint
/home/andrea/rpmbuild/RPMS/x86_64/fs-uae-2.6.2-1.fc23.x86_64.rpm
fs-uae.x86_64: W: spelling-error %description -l en_US ctrl -> ctr, curl, ctr l
fs-uae.x86_64: E: zero-length /usr/share/fs-uae/theme.conf
fs-uae.x86_64: E: zero-length /usr/share/fs-uae/share-dir
fs-uae.x86_64: W: no-manual-page-for-binary fs-uae-device-helper
fs-uae.x86_64: W: no-manual-page-for-binary fs-uae
1 packages and 0 specfiles checked; 2 errors, 3 warnings.
[andrea@panoramix SPECS]$ rpmlint
/home/andrea/rpmbuild/RPMS/x86_64/fs-uae-debuginfo-2.6.2-1.fc23.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3 years, 6 months
[Bug 5801] New: Review request: loudgain - ReplayGain 2.0 audio
loudness normalizer
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5801
Bug ID: 5801
Summary: Review request: loudgain - ReplayGain 2.0 audio
loudness normalizer
Product: Package Reviews
Version: Current
Hardware: x86_64
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-review(a)rpmfusion.org
Reporter: rpmfusion.org(a)mavit.org.uk
CC: rpmfusion-package-review(a)rpmfusion.org
namespace: free
Spec URL: https://www.mavit.org.uk/loudgain/loudgain.spec
SRPM URL: https://www.mavit.org.uk/loudgain/loudgain-0.6.8-1.fc32.src.rpm
loudgain is a versatile ReplayGain 2.0 loudness normalizer, based on the
EBU R128/ITU BS.1770 standard (-18 LUFS) and supports
FLAC/Ogg/MP2/MP3/MP4/M4A/ALAC/Opus/ASF/WMA/WAV/WavPack/AIFF/APE audio
files. It uses the well-known mp3gain commandline syntax but will never
modify the actual audio data.
This package is not eligible to be included in Fedora because it depends on
ffmpeg.
$ rpmlint loudgain-0.6.8-1.fc32.src.rpm
loudgain.src: W: spelling-error Summary(en_US) normalizer -> normalize,
normalizes, normalized
loudgain.src: W: spelling-error %description -l en_US normalizer -> normalize,
normalizes, normalized
loudgain.src: W: spelling-error %description -l en_US commandline -> command
line, command-line, commandment
loudgain.src: W: patch-not-applied Patch0: hardened-build.patch
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
The spellings seem fine to me.
The patch is applied by %forgeautosetup, which appears not to be recognised by
rpmlint.
$ rpmlint loudgain-0.6.8-1.fc32.x86_64.rpm
loudgain.x86_64: W: spelling-error Summary(en_US) normalizer -> normalize,
normalizes, normalized
loudgain.x86_64: W: spelling-error %description -l en_US normalizer ->
normalize, normalizes, normalized
loudgain.x86_64: W: spelling-error %description -l en_US commandline -> command
line, command-line, commandment
loudgain.x86_64: W: no-manual-page-for-binary rgbpm
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Upstream do not provide a man page for the rgbpm script.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
3 years, 10 months
[Bug 2151] New: Review request: perle-serial-kmod - Perle Serial PCI card kernel module(s)
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2151
Bug #: 2151
Summary: Review request: perle-serial-kmod - Perle Serial PCI
card kernel module(s)
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: philipp(a)redfish-solutions.com
CC: rpmfusion-package-review(a)rpmfusion.org
Perle Systems makes several PCI and PCIe serial cards, but there support for
linux 2.6 and 3.x is lacking.
This package patches their driver tarball and builds it as per rpmfusion as
kmod.
ftp://ftp.redfish-solutions.com/pub/perle-serial-kmod.spec
ftp://ftp.redfish-solutions.com/pub/perle-serial-kmod-3.8.0-6.1.fc16.1.sr...
== description ==
This package provides a driver for the family of Perle serial cards.
The cards supported are:
Perle UltraPort1, 2, 4, 8, 8i, and 16 cards
Perle UltraPort1, 2, 4, 8, 8i, and 16 SI cards
Perle UltraPort1, 2, 4, 8, and 8i Express cards
Perle PCI-RAS V.92 (4 and 8 port) cards
Perle Speed1, 2, 4, and 8 LE cards
Read /usr/share/doc/perle-serial/README for more info.
====
This is a kmod package, and as such can't be included in Fedora.
====
$ rpmlint perle-serial-kmod.spec
perle-serial-kmod.spec:44: W: mixed-use-of-spaces-and-tabs (spaces: line 44,
tab: line 6)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$
The spaces come as a result of cut&paste of taking the description directly
from upstream files.
$ rpmlint ../RPMS/x86_64/*perle-serial*
kmod-perle-serial-3.1.9-1.fc16.x86_64.x86_64: W: summary-not-capitalized C
perle-serial kernel module(s) for 3.1.9-1.fc16.x86_64
kmod-perle-serial-3.1.9-1.fc16.x86_64.x86_64: W: unstripped-binary-or-object
/lib/modules/3.1.9-1.fc16.x86_64/extra/perle-serial/perle-serial.ko
kmod-perle-serial-3.1.9-1.fc16.x86_64.x86_64: W: no-documentation
kmod-perle-serial.x86_64: W: spelling-error Summary(en_US) Metapackage -> Meta
package, Meta-package, Prepackage
kmod-perle-serial.x86_64: W: no-documentation
perle-serial-kmod-common.x86_64: W: spelling-error Summary(en_US) userland ->
user land, user-land, slanderous
perle-serial-kmod-common.x86_64: W: spelling-error %description -l en_US
Userland -> User land, User-land, Slanderous
perle-serial-kmod-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/perle-serial-kmod-3.8.0/_kmod_build_3.1.9-1.fc16.x86_64/perle-serial.c
4 packages and 0 specfiles checked; 1 errors, 7 warnings.
$
"Userland" and "Metapackage" are legitimate words in this lexicon.
The wrong FSF address in perle-serial.c is directly from the upstream sources.
Kernel modules are unstripped (or they wouldn't load otherwise).
The not capitalized warning applies to a string that's generated from a macro.
The documentation is in the -common package.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4 years
[Bug 2221] New: Review request: libarea - Library that allows for creating tool paths for pocketing
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2221
Bug #: 2221
Summary: Review request: libarea - Library that allows for
creating tool paths for pocketing
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: SpikeFedora(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Spec URL:
http://spike.fedorapeople.org/libarea/libarea.spec
SRPM URL:
http://spike.fedorapeople.org/libarea/libarea-0.0.2-0.1.20111215git599996...
Description:
LibAREA is a library that allows for creating tool paths for pocketing.
Why this package is not eligible to be included in Fedora:
"Some software is not functional or useful without the presence of external
code dependencies in the runtime operating system environment. When those
external code dependencies are non-free, legally unacceptable, or binary-only
[...], then the dependent software is not acceptable for inclusion in
Fedora"[1]
Since atm only HeeksCNC uses this lib and HeeksCNC depends on OCE
(HeeksCNC->HeeksCAD-devel->OCE-devel), which is considered non-free, I assume
the term "not useful" applies here.
[1] http://fedoraproject.org/wiki/Packaging:Guidelines
rpmlint output:
SPECS/libarea.spec: W: invalid-url Source0: libarea-svnHEAD.tar.bz2
libarea.src: W: invalid-url Source0: libarea-svnHEAD.tar.bz2
1 packages and 1 specfiles checked; 0 errors, 2 warnings.
Upstream doesn't provide a release package tarball.
Careful: I usually don't do any python packaging. Here be dragons!
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4 years
[Bug 2599] New: Review request: libshout-idjc - Icecast source streaming library modified for IDJC
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2599
Bug #: 2599
Summary: Review request: libshout-idjc - Icecast source
streaming library modified for IDJC
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: comzeradd(a)fedoraproject.org
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
SPEC: http://comzeradd.fedorapeople.org/specs/libshout-idjc.spec
SRPM: http://comzeradd.fedorapeople.org/libshout-idjc-2.3.0-1.fc17.src.rpm
The libshout is a library for communicating with and sending data to an icecast
server. It handles the socket connection, the timing of the data, and prevents
most bad data from getting to the icecast server. libshout-idjc is a modified
version of libshout library with extra functionality needed by idjc.
This is package can not be include in Fedora main repos because it contains
code for supporting non-free codecs (eg. AAC).
$ rpmlint libshout-idjc-2.3.0-1.fc17.src.rpm
libshout-idjc.src: W: spelling-error Summary(en_US) Icecast -> Ice cast,
Ice-cast, Icecap
libshout-idjc.src: W: spelling-error %description -l en_US icecast -> ice cast,
ice-cast, icecap
$ rpmlint libshout-idjc-2.3.0-1.fc17.x86_64.rpm
libshout-idjc.x86_64: W: spelling-error Summary(en_US) Icecast -> Ice cast,
Ice-cast, Icecap
libshout-idjc.x86_64: W: spelling-error %description -l en_US icecast -> ice
cast, ice-cast, icecap
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
This is my first RPM Fusion package, but I am a Fedora Packager.
https://admin.fedoraproject.org/pkgdb/users/packages/comzeradd
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4 years