[Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #12 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-28 22:37:15 CET
---
(In reply to comment #11)
The bundled libprojectM is forked from version 1.2. The version in
Fedora is
2.0. There's a reason they call it "XBMCProjectM".
Ok, fair enough.
The afpfs-ng, libcec, libdvdread, and zlib packages from Fedora are
already
being used.
That's great, but I think it would be good to actually remove them from the
generated source tree, if for no other reasons than to guarantee that they
aren't being built.
Please note that licensecheck will list files that are conditionally
compiled
for Windows, OS X, or Android/ARM. The GPL is the main license that everything
will fall under. Since some of the code is compiled into libraries
(/usr/lib/kodi/system) I will include the licenses for them and the license
files for eventclients.
Thank you. This looks good now.
In regards to arched-Requires: This package is not multi-lib.
Maybe not, but the libraries are multi-lib. If, for some strange reason, I
have libcec.i686 installed, but not libcec.x86_64, installing kodi won't bring
in libcec.x86_64. The manual requires need to have arched-Requires.
You could argue that
http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
doesn't apply to kodi's devel packages because they're not multi-lib, but
I'd
probably do it anyway, just to be safe.
Apart from all that, do you have thoughts on the man pages and the ExcludeArch?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.