[Bug 2205] Review request: sox-plugins-freeworld
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2205
--- Comment #5 from Alec Leamas <leamas.alec(a)gmail.com> 2012-03-22 00:59:34 CET ---
Some initial remarks:
No license break-down
(http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Lice...)
Contains bundled libgsm (~fedora package gsm-devel). Package seems to link
to system libgsm, but the bundled lib is not removed in %prep as required
in http://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries.
Contains bundled lpc10. lpc10 seems to be part of spandsp-devel. This might
mean that this could be used to provide lpc10. It might also mean that a
bundling bug should be filed against spandsp-devel instead, while packaging
lpc10 separately (which at least Mandriva do).
Is the realname macro useful? I doubt the package name will ever change,
and it's only expanded in one place anyway.
For some reason, the build fails on my F16 host. Another, F15, works fine as do
mock. Something is rotten here, I'll try to find out what.
I have
%__arch_install_post /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot
in my .rpmmacros. This triggers the following in build, after %install:
ERROR 0002: file '/usr/lib64/sox/libsox_fmt_mp3.so' contains an invalid rpath
~/rpmbuild/BUILD/sox-14.3.2/src/.libs' which is discouraging.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.