[Bug 3429] Review request: frobtads - Text interpreter for Tads games
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3429
--- Comment #3 from František Dvořák <valtri(a)civ.zcu.cz> 2015-12-28 23:59:09 CET
---
Thanks for the reviews! Both packages have some complications - like the
complex licensing and bundled stuff...
(In reply to comment #2)
Needs work:
========
-license text not in %license, the actual license text is in tads3/LICENSE.TXT
so the %license line should read:
%license doc/COPYING tads3/LICENSE.TXT
I overlook that, good catch. Fixed.
-Package does not build, this is caused by you moving the installed
tads manual
to %{_pkgdocdir}-devel
but not having a matching %doc line in %files. For the review I've fixed this
by replacing the mkdir + mv
you do after make install with:
rm -rf %{buildroot}%{_datadir}/frobtads/tads3/doc
and adding the docs in question to "%files devel" like this:
%doc doc/COMPILERS tads3/doc/*
Letting rpmbuild take care if the installation of the docs, which usually is
the best way to deal with docs
Right, fixed this way.
-Why is %{_datadir}/frobtads/tads2 owned by the -devel pkg and not by
the main
pkg ?
These files are include files used only by Tads 2 compiler. I placed header
files and the compilers (+ the TADS includes) into the -devel subpackage.
On other hand, tads3/res/charmap/cmaplib.t3r is needed for runtime and in the
main package.
Updated version:
Spec URL: http://scientific.zcu.cz/fedora/frobtads-1.2.3-1b/frobtads.spec
SRPM URL:
http://scientific.zcu.cz/fedora/frobtads-1.2.3-1b/frobtads-1.2.3-1.fc24.s...
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.