[Bug 2819] Review Request: OpenCaster - Free digital TV software

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2819 Antonio <anto.trande(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande(a)gmail.com --- Comment #1 from Antonio <anto.trande(a)gmail.com&gt; 2013-05-31 19:27:14 CEST --- Hi Marco. I'm not a sponsor so I can just do some comments. ;) - You don't need rm -rf $RPM_BUILD_ROOT anymore if your package is destined to a recent Fedora release and a RHEL/CentOS 6. - Too complex, a right option of the 'mkdir' command is sufficient ;) - Try to use more properly all macro available; for example: $RPM_BUILD_ROOT/usr/share/%{name}/%{version} becomes $RPM_BUILD_ROOT/%{_datadir}/%{name}/%{version} See http://fedoraproject.org/wiki/Packaging:RPMMacros - In my opinion, all files must be explicated better in the %files section. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.