[Bug 2921] Review request: openmw - Unofficial open source engine re-implementation of the game Morrowind

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2921 Richard <hobbes1069(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069(a)gmail.com --- Comment #6 from Richard <hobbes1069(a)gmail.com&gt; 2013-08-31 14:11:29 CEST --- Some additional comments. 1. Unless they're closely related packages, everything in the BuildRequires section should really be one per line. It's very difficult to read through them like they are. 2. Are you sure you need to BuildRequires: tbb and not tbb-devel? 3. C programs very rarely need to "Requires: ..." anything. Almost all dependencies should be found through soname dependencies and picked up by RPM automatically. Exceptions would be noarch script based packages such as python or possibly dlopen situations... 4. You can optionally use the "%make_install" macro instead of doing the long form... 5. You should have one blank line between changelog entries for legibility. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.