[Bug 3539] Review Request: kwave - Sound Editor for KDE
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3539
--- Comment #8 from Mario Blättermann <mario.blaettermann(a)gmail.com> 2015-02-15
23:08:37 CET ---
(In reply to comment #7)
better to use this patch:
# Fix gzipped-svg-icon
(
cd %{buildroot}%{_datadir}/icons/hicolor/scalable/actions
for i in *.svgz;
do
zcat "$i" > $(basename "$i" ".svgz").svg && rm
-f "$i"
done
cd %{buildroot}%{_datadir}/icons/hicolor/scalable/apps
zcat kwave.svgz > kwave.svgz.sv && rm -f kwave.svgz
)
I've already converted the application icon into png, that's the only one which
can cause problems in non-KDE environments. The remaining gzipped icons are
only used internally in kwave itself.
(In reply to comment #3)
[ ]: License field in the package spec file matches the actual
license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or
later)",
"BSD (2 clause) GPL (v2 or later)", "Unknown or generated". 2
files have
unknown license.
should be: GPLv2+ and BSD and not GPLv2+ and CC-BY-SA
CC-BY-SA is the license of the icons. But indeed, the file
plugins/codec_ogg/OpusEncoder.cpp is dual-licensed as GPL and BSD, because it
contains some code snippets from opus-tools. I've added the latter to the spec
file.
Spec URL: https://mariobl.fedorapeople.org/Review/SPECS/kwave.spec
SRPM URL:
https://mariobl.fedorapeople.org/Review/SRPMS/kwave-0.8.99-7.fc21.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.