[Bug 3034] Review Request: lpf-skype: Skype internet phone client package bootstrap
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3034
--- Comment #24 from Simone Caronni <negativo17(a)gmail.com> 2013-12-04 16:20:20 CET
---
All modifications done in CVS.
(In reply to comment #22)
- The build error exposes an lpf bug which will require an update
(under
way). This will probably mean R/BR: lpf >= 0.13
Added.
- Please disable debug package generation.
Fixed.
- Perhaps expand the description a little: mention that this is a
i686 package
to be used on both i686/x86_64, add the skype upstream url.
Added, same format as lpf-flash-plugin.spec.
(In reply to comment #23)
- update-desktop-database is invoked in %post and %postun if package
contains
desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in skype-data
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
Fixed, replaced old mime database.
- %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/prelink.conf.d/skype-x86_64.conf
%config /etc/dbus-1/system.d/skype.conf
Made notes in the spec file why they should be always replaced.
- Useful -debuginfo package or justification otherwise (justification
missing).
Fixed by removing debug generation.
- Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define debug_package %{nil},
%define __spec_install_post /usr/lib/rpm/brp-compress
Fixed, added explanation as well.
skype-data.noarch: E: description-line-too-long C This package
contains icons,
sounds and support files for the main Skype package.
skype-data.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/skype-data-4.2.0.11/LICENSE
skype.src:30: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 30)
All fixed.
I've left only this:
Rpmlint: please fix
skype.i686: W: name-repeated-in-summary C Skype
The description matches the way it's referenced everywhere on Skype's website
and how the package is originally called, so I left it as is.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.