[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098
--- Comment #60 from Jeremy Newton <alexjnewt(a)hotmail.com> 2012-06-25 16:36:46 CEST
---
(In reply to comment #58)
No problem :)
The patch is already committed upstream (although I think the commit was to fix
another problem).
Thanks, I'll make note of it in the spec
(In reply to comment #59)
I had a very quick glance at the package and I notice that the spec
doesn't
require hicolor-icon-theme. Any application installing icons to hicolor MUST
Require hicolor-icon-theme. The purpose of hicolor-icon-theme is to be required
by any package which installs any icons. It contains no actual icons, but just
an empty theme for applications to install their icons into.
Good eye, thanks!
Here's an updated spec; I'm just waiting on a SCM request for CLRun to unblock
this. Note that I changed the package name of CLRun, so to install, one would
have to uninstall open-utils-CLRun in favour for the new package to avoid a
file conflict.
SPEC:
http://dl.dropbox.com/u/42480493/dolphin-emu.spec
SRPM:
http://dl.dropbox.com/u/42480493/dolphin-emu-3.0-10.fc17.src.rpm
Current RPMLINT Ouput:
dolphin-emu.src: W: spelling-error Summary(en_US) Gamecube -> Game cube,
Game-cube, Gamecock
dolphin-emu.x86_64: W: spelling-error Summary(en_US) Gamecube -> Game cube,
Game-cube, Gamecock
dolphin-emu.src: W: invalid-url Source1: dolphin-emu-extra.tar.xz
dolphin-emu.src: W: invalid-url Source0: dolphin-emu-3.0.tar.xz
dolphin-emu-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dolphin-emu-3.0/Source/Core/Core/Src/DSP/DSPHWInterface.cpp
...
dolphin-emu-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dolphin-emu-3.0/Source/Core/Core/Src/DSP/DSPIntExtOps.h
3 packages and 0 specfiles checked; 13 errors, 4 warnings.
The FSF Address issue has been fixed in the unstable version, the invalid-url
can be safely ignored due to the nature of the source files, and gamecube is
obviously not in the dictionary.
I'm just waiting to push this:
https://bugzilla.redhat.com/show_bug.cgi?id=810059
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.