[Bug 2531] Review request: moc - Music on Console - Console audio player for Linux/UNIX

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531 --- Comment #3 from Elder Marco <eldermarco(a)gmail.com&gt; 2012-10-18 21:50:58 CEST --- OK. Just a few more comments. * Use %doc for the documentation [1]; * You still should own the directory %{_datadir}/%{name} [2]. You can do it by adding this line at the %files section: %dir %{_datadir}/%{name} or you can own this directory and all files and directories inside it: %{_datadir}/%{name} In this case, you don't need to list the files or directories inside it. * About the Source URL, read [3] and try to change the URL if possible. Cosmetic changes: =========== * I don't think it is mandatory but for readability reasons it would be nice if you add 'Requires' tag after 'BuildRequires'. Also, add a blank line between them and after the 'Source0' tag: Source0: <tarball_url> <blank line> BuildRequires: <package1> BuildRequies: <package2> .... BuildRequires: <packageN> <blank line> Requires: <another_package1> Requires: <another_package2> .... Requires: <another_packageN> <blank line> [1] - http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation [2] - http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Own... [3] - http://fedoraproject.org/wiki/Packaging:SourceURL -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.