[Bug 1024] Review request: pushover - Fun puzzle game with dominos
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1024
Xavier Bachelot <xavier(a)bachelot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
Status|NEW |ASSIGNED
--- Comment #3 from Xavier Bachelot <xavier(a)bachelot.org> 2010-01-05 00:24:29 ---
OK: spec file is properly named
OK: package is properly named
OK: Spec is legible
NOK: use of macros is consistent
spurious %{buildroot} when installing the desktop file
OK: tarball match upstream :
b0b6b584a57db0ca6ec69647fba67369
NOK: License field match the actual license and is acceptable
The non-free artwork should be acknowledge for.
Actually, I'm not sure the package is acceptable until all the proprietary
artwork from the original game has been replaced.
Ok: BuildRoot is correct
OK: BuildRequires and Requires are correct
OK: no bundled copied of libraries
OK: Desktop file is validated and installed
OK: scriplets are correct.
OK: locales are properly handled
OK: defattr is correct
OK: %doc is correct and not needed at runtime
Ok: builds in mock
OK: all files and directories are properly packaged
OK: doesn't own dirs it shouldn't
OK: files/dirs perms are correct
OK: files/dirs names are UTF-8
OK; rpmlint output is clean ;
pushover.i686: W: dangling-symlink /usr/share/pushover/data/FreeSans.ttf
/usr/share/fonts/gnu-free/FreeSans.ttf
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
The warning is expected and can be ignored.
Ok: final provides and requires are correct
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.