[Bug 4441] Review request: discord - All-in-one voice and text chat for gamers

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4441 Andrew Bauer <zonexpertconsulting(a)outlook.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zonexpertconsulting@outlook | |.com --- Comment #10 from Andrew Bauer <zonexpertconsulting(a)outlook.com&gt; --- Was going to submit a new request for Discord when I noticed you beat me to the punch. I'm new to rpmfusion too, but if no one else picks up this review I will assign it to myself. -> Remind me <- The biggest issue I see with this application is the lack of any kind of licensing or distribution statement. I have not been able to find it either in the tarball, the deb package, or their website. From my experience on the Fedora side, even an email from the author stating their license (include all email headers) is sufficient. That would be my recommendation, but naturally I'd defer to Nicolas since he is the senior member. Moving on the contents of your specfile, here is some initial things that I would change: - move %global declarations to the very top - replace all paths with their macro counterparts: /usr/lib64 -> %{_libdir} /usr/share -> %{_datadir} - %defattr(-,root,root) is now the default and should be removed - rm -rf $RPM_BUILD_ROOT is now the default and should be removed - buildrequires sed - buildrequires coreutils (some say this is optional depending on who you ask) - %clean section no longer required and should be removed If you aren't sure if something might be part of an rpm macro, this is what I do to find out: rpm --showrc | grep {text or pathname in question} If one picks apart the deb package from the Discord site, there is a long list of dependencies. We should verify the rpm matches that, and if it doesn't take a closer look. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.