[Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders

http://bugzilla.rpmfusion.org/show_bug.cgi?id=527 Orcan Ogetbil <oget.fedora(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |3 Status|NEW |ASSIGNED --- Comment #14 from Orcan Ogetbil <oget.fedora(a)gmail.com&gt; 2009-04-16 07:21:23 --- Since you got sponsored, things can go faster now. Here is a more thorough review: * rpmlints: mlt.i586: W: shared-lib-calls-exit /usr/lib/libmiracle.so.0.3.8 exit(a)GLIBC_2.0 So this isn't removed in this release. What happened? mlt-devel.i586: W: spurious-executable-perm /usr/share/doc/mlt-devel-0.3.8/demo/demo mlt-devel.i586: W: doc-file-dependency /usr/share/doc/mlt-devel-0.3.8/demo/demo /bin/bash These two can be eliminated by doing a chmod -x demo/demo in %prep. * Shouldn't group tag for the main package be System Environment/Libraries ? ! All relevant doc files should be packaged. ./src/modules/motion_est/README can go to the %doc of the main package * Please add BuildRequires: frei0r-devel * src/modules/jackrack/plugin_mgr.c has /usr/local/lib/ladspa:/usr/lib/ladspa hardcoded, which won't work on 64bit systems. Please fix this. ? Why do you rename all the executables but "inigo"? * rawhide buildlog says: - libquicktime not found: only enabling dv avi support This is because it can't find lqt-config. See: https://bugzilla.rpmfusion.org/show_bug.cgi?id=265 http://cvs.rpmfusion.org/viewvc/rpms/libquicktime/devel/libquicktime.spec... You need to patch this up so it can find the libquicktime properly. * Similarly, mlt-config shouldn't be packaged (the file itself says it is deprecated) or it will break multilib. You can use %exclude in %files to exclude it. * I don't think you need these lines in the SPEC: BuildRequires: prelink and # clear-execstack execstack -c $RPM_BUILD_ROOT%{_libdir}/%{name}/libmltgtk2.so * I also think that you don't need this BuildRequires: alsa-lib-devel * Each package must consistently use macros, as described in the macros section of Packaging Guidelines . Please make use of the %{name} macro extensively (except maybe URL), or do not use it at all. * Running mlt-miracle gives "segmentation fault" ! SPEC file improvement: You don't needs these lines install -d docs/demo cp -p demo/* docs/demo Adding "demo" after "docs/*" will be sufficient. i.e. ... %files devel %defattr(-,root,root,-) %doc docs/* demo ... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.