[Bug 479] Review Request: xmms-mplayer - MPlayer plugin for XMMS
http://bugzilla.rpmfusion.org/show_bug.cgi?id=479
--- Comment #5 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-21 19:25:49 ---
Thanks for the review!
(In reply to comment #4)
NEEDSWORK
- I can't find a single mention of a license in the tarball, webpage states
its contents is licensed under GPL. Please contact author to get license
headers in source code.
There is a COPYING file that contains the GPL text. I also sent an email
upstream with the request of adding license info to source headers but I doubt
that this will be taken into consideration as the project is pretty much dead
(No activity for 5+ years).
- Time stamps are not preserved in make install, but the only things
installed are compiled files. However it would be nice to preserve time
stamps for those, too.
Okay, I added a "INSTALL=install -p"
NEEDSWORK
- Add explicit Requires: xmms-libs for dir ownership. (Although this is
pulled in by xmms's requirement on libxmms.so.1)
This is totally unnecessary. xmms is a very well established old package. It
will always depend on xmms-libs. I'd like to keep BR's and R's minimal.
- You might want to add a
[ -s NEWS ] && exit 1
to the setup phase so that if NEWS becomes a non-empty file the build fails.
Uhm... Why? As I said, the project is dead.
Well, I added it anyways.
SPEC: http://6mata.com:8014/review/xmms-mplayer.spec
SRPM: http://6mata.com:8014/review/xmms-mplayer-0.5-2.fc10.src.rpm
Changelog: 0.5-2
- Use "install -p".
- Add [ -s NEWS ] && exit 1
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.