[Bug 3102] Review Request: vdr-softhddevice - A software and GPU emulated HD output device plugin for VDR
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3102
Alec Leamas <leamas.alec(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Blocks|2 |3
--- Comment #15 from Alec Leamas <leamas.alec(a)gmail.com> 2014-01-10 17:06:05 CET
---
(In reply to comment #14)
(In reply to comment #10)
> The fedora config file is fine just the user finds it. But generally
> speaking, she will not do this since she will look in the docs for it.
> Hence a specific README.fedora is probably needed which just says that
> the configuration file is added. No blocker.
"works" as-is.
Obviously, we disagree here. Fine with me.
> The configuration seems somewhat messy. The Makefile looks for a
pkgconfig
> file, but vdr-devel does not provide this. OTOH vdr-devel does provide
> a vdr-config binary, but this is not used in the Makefile. Probably worth
> reporting upstream. If you maintain vdr-devel (?), you could just add a
> pkgconfig .pc file to it so things are more consistent. Or patch Makefile to
> use vdr-config. No blocker, it sort of "works" as-is.
Makefile checks this with /usr/lib64/pkgconfig/vdr.pc (vdr-devel package)
Yes,
sorry, my bad. I missed that vdr-devel actually provided the .pc file
Now, this looks much better. Actually, it looks good. Time to make a review.
Assigning.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.