[Bug 3964] Review request: qtav - A media playback framework based on Qt and FFmpeg

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3964 Antonio Trande <anto.trande(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |4 --- Comment #10 from Antonio Trande <anto.trande(a)gmail.com&gt; 2016-02-11 12:15:41 CET --- Is it not enough erasing them in %prep section ? Review passed. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "GPL (v3.0) LGPL (v3.0)", "LGPL (v2.1)", "BSD (3 clause)", "BSD (2 clause)", "LGPL (v2.1 or later)", "LGPL (v2.1 or v3)". 102 files have unknown license. Detailed output of licensecheck in /home/sagitter/FedoraReview/qtav/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/scalable/apps, /usr/lib64/qt5/bin, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in qtav-players [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in qtav-players [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libqtav , qtav-qml-module , qtav-debuginfo [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: libqtav-1.9.0-0.5.gited374dc.fc24.x86_64.rpm libqtavwidgets-1.9.0-0.5.gited374dc.fc24.x86_64.rpm qtav-devel-1.9.0-0.5.gited374dc.fc24.x86_64.rpm qtav-qml-module-1.9.0-0.5.gited374dc.fc24.x86_64.rpm qtav-players-1.9.0-0.5.gited374dc.fc24.x86_64.rpm qtav-debuginfo-1.9.0-0.5.gited374dc.fc24.x86_64.rpm qtav-1.9.0-0.5.gited374dc.fc24.src.rpm libqtav.x86_64: W: shared-lib-calls-exit /usr/lib64/libQtAV.so.1.9.0 exit(a)GLIBC_2.2.5 libqtavwidgets.x86_64: W: no-documentation qtav-devel.x86_64: W: only-non-binary-in-usr-lib qtav-devel.x86_64: W: no-documentation qtav-players.x86_64: E: script-without-shebang /usr/share/icons/hicolor/scalable/apps/QtAV.svg qtav-players.x86_64: W: no-manual-page-for-binary QMLPlayer qtav-players.x86_64: W: no-manual-page-for-binary player qtav-players.x86_64: W: desktopfile-without-binary /usr/share/applications/QMLPlayer.desktop QMLPlayer qtav-players.x86_64: W: desktopfile-without-binary /usr/share/applications/player.desktop player qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.rcc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.rcc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.moc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.moc qtav.src: W: spelling-error %description -l en_US suppprt -> support qtav.src: W: spelling-error %description -l en_US rgb -> rib, rob, rub qtav.src: W: spelling-error %description -l en_US yuv -> guv, yum, yup qtav.src: W: spelling-error %description -l en_US libavfilter -> filibusterer qtav.src: W: spelling-error %description -l en_US http -> HTTP qtav.src: W: spelling-error %description -l en_US rtsp -> tsp, resp, rasp qtav.src: W: spelling-error %description -l en_US eq -> e, q, seq 7 packages and 0 specfiles checked; 1 errors, 19 warnings. Rpmlint (debuginfo) ------------------- Checking: qtav-debuginfo-1.9.0-0.5.gited374dc.fc24.x86_64.rpm qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.rcc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.rcc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.moc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.moc 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.moc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.moc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.rcc qtav-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/QtAV-ed374dc559f1689288579e19f23b4f6c92633adc/build/.rcc qtav-devel.x86_64: W: only-non-binary-in-usr-lib qtav-devel.x86_64: W: no-documentation qtav-players.x86_64: E: script-without-shebang /usr/share/icons/hicolor/scalable/apps/QtAV.svg qtav-players.x86_64: W: no-manual-page-for-binary QMLPlayer qtav-players.x86_64: W: no-manual-page-for-binary player libqtav.x86_64: W: shared-lib-calls-exit /usr/lib64/libQtAV.so.1.9.0 exit(a)GLIBC_2.2.5 libqtavwidgets.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 1 errors, 10 warnings. Requires -------- qtav-qml-module (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Quick.so.5(Qt_5_PRIVATE_API)(64bit) libQtAV.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) qtav-debuginfo (rpmlib, GLIBC filtered): qtav-devel (rpmlib, GLIBC filtered): libQtAV.so.1()(64bit) libQtAVWidgets.so.1()(64bit) libqtav(x86-64) libqtavwidgets(x86-64) qt5-qtbase-devel qtav-players (rpmlib, GLIBC filtered): /bin/sh libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQtAV.so.1()(64bit) libQtAVWidgets.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libqtav(x86-64) libqtavwidgets(x86-64) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) qtav-qml-module(x86-64) rtld(GNU_HASH) libqtav (rpmlib, GLIBC filtered): /sbin/ldconfig ffmpeg libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libass.so.5()(64bit) libavcodec.so.56()(64bit) libavcodec.so.56(LIBAVCODEC_56)(64bit) libavdevice.so.56()(64bit) libavdevice.so.56(LIBAVDEVICE_56)(64bit) libavfilter.so.5()(64bit) libavfilter.so.5(LIBAVFILTER_5)(64bit) libavformat.so.56()(64bit) libavformat.so.56(LIBAVFORMAT_56)(64bit) libavresample.so.2()(64bit) libavresample.so.2(LIBAVRESAMPLE_2)(64bit) libavutil.so.54()(64bit) libavutil.so.54(LIBAVUTIL_54)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libpthread.so.0()(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libswresample.so.1()(64bit) libswresample.so.1(LIBSWRESAMPLE_1)(64bit) libswscale.so.3()(64bit) libswscale.so.3(LIBSWSCALE_3)(64bit) libva.so.1()(64bit) libva.so.1(VA_API_0.33.0)(64bit) rtld(GNU_HASH) libqtavwidgets (rpmlib, GLIBC filtered): /sbin/ldconfig libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5OpenGL.so.5()(64bit) libQt5OpenGL.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQtAV.so.1()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXv.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libqtav(x86-64) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- qtav-qml-module: libQmlAV.so()(64bit) qtav-qml-module qtav-qml-module(x86-64) qtav-debuginfo: qtav-debuginfo qtav-debuginfo(x86-64) qtav-devel: qtav-devel qtav-devel(x86-64) qtav-players: application() application(QMLPlayer.desktop) application(player.desktop) mimehandler(application/ogg) mimehandler(application/sdp) mimehandler(application/smil) mimehandler(application/streamingmedia) mimehandler(application/vnd.rn-realmedia) mimehandler(application/vnd.rn-realmedia-vbr) mimehandler(application/x-ogg) mimehandler(application/x-smil) mimehandler(application/x-streamingmedia) mimehandler(audio/AMR) mimehandler(audio/aac) mimehandler(audio/ac3) mimehandler(audio/flac) mimehandler(audio/m4a) mimehandler(audio/mp1) mimehandler(audio/mp2) mimehandler(audio/mp3) mimehandler(audio/mpeg) mimehandler(audio/mpegurl) mimehandler(audio/mpg) mimehandler(audio/rn-mpeg) mimehandler(audio/scpls) mimehandler(audio/vnd.rn-realaudio) mimehandler(audio/wav) mimehandler(audio/x-aac) mimehandler(audio/x-ape) mimehandler(audio/x-flac) mimehandler(audio/x-m4a) mimehandler(audio/x-mp1) mimehandler(audio/x-mp2) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-mpg) mimehandler(audio/x-ms-wma) mimehandler(audio/x-pls) mimehandler(audio/x-pn-realaudio) mimehandler(audio/x-pn-windows-pcm) mimehandler(audio/x-realaudio) mimehandler(audio/x-scpls) mimehandler(audio/x-shorten) mimehandler(audio/x-tta) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-wav) mimehandler(audio/x-wavpack) mimehandler(video/mp2t) mimehandler(video/mp4) mimehandler(video/mpeg) mimehandler(video/msvideo) mimehandler(video/quicktime) mimehandler(video/vnd.rn-realvideo) mimehandler(video/webm) mimehandler(video/x-avi) mimehandler(video/x-fli) mimehandler(video/x-flv) mimehandler(video/x-matroska) mimehandler(video/x-mpeg) mimehandler(video/x-mpeg2) mimehandler(video/x-ms-afs) mimehandler(video/x-ms-asf) mimehandler(video/x-ms-wmv) mimehandler(video/x-ms-wmx) mimehandler(video/x-ms-wvxvideo) mimehandler(video/x-msvideo) mimehandler(video/x-ogm+ogg) mimehandler(video/x-theora) qtav-players qtav-players(x86-64) libqtav: libQtAV.so.1()(64bit) libqtav libqtav(x86-64) libqtavwidgets: libQtAVWidgets.so.1()(64bit) libqtavwidgets libqtavwidgets(x86-64) Unversioned so-files -------------------- qtav-qml-module: /usr/lib64/qt5/qml/QtAV/libQmlAV.so Source checksums ---------------- https://github.com/wang-bin/QtAV/archive/ed374dc559f1689288579e19f23b4f6c... : CHECKSUM(SHA256) this package : 96f22c64f9a7dd899e841be930e6d3c3a7e8fe982c3b47b71115aef7fcae80ef CHECKSUM(SHA256) upstream package : 96f22c64f9a7dd899e841be930e6d3c3a7e8fe982c3b47b71115aef7fcae80ef Generated by fedora-review 0.6.0 (7737a2a) last change: 2015-11-26 Command line :./try-fedora-review --plugins Java:on -m fedora-rawhide-x86_64-rpmfusion_free -rn qtav-1.9.0-0.5.gited374dc.fc23.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java, C/C++ Disabled plugins: Python, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.