http://bugzilla.rpmfusion.org/show_bug.cgi?id=396
--- Comment #14 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-03 18:47:31 ---
Thanks. A few comments:
* Upstream provides a tarball on their website:
http://code.google.com/p/paint-mono/downloads/list
Any reason why that one is not used?
* Is it really not possible to replace the offending artwork by some free
artwork?
* Any possible license issues with Sources 3-6 ? You should explain where and
how to get them in the SPEC file.
* Similarly, the patches should be explained, and if they are not Fedora
specific, sent upstream. Links from their upstream should be provided.
* Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
* Please don't use a --vendor flag on desktop-file-install
* %attr(0644,root,root) is not needed
! %dir %{_libdir}/%{name}
%{_libdir}/%{name}/*
can be replaced by just
%{_libdir}/%{name}/
* Any reason why you use
./configure --prefix=%{_prefix} --libdir=%{_libdir}
instead of just
%configure
?
* Please update to the latest icon cache scriptlets:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
--
Configure bugmail:
http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.