[Bug 2455] Review request: pcsx2 - A Sony Playstation2 emulator

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2455 --- Comment #3 from Giles Birchley <gbirchley(a)blueyonder.co.uk&gt; 2012-08-26 17:03:37 CEST --- Hi Andrea, Thank-you very much for looking at my package and offering your advice. I've complied with what you've said in most cases but have just a few queries. I'll reply to your comments one by one: The License field has been updated (shortened!) I have followed the revision control packaging guidelines. I think the Name realease version is correct as I have specifically packaged a revision 1.0, rather than a subversion revision, as this should now see no further activity. The release has been named (2) because it is an update of the rpm that I make available on the PCSX2 forums I am not sure about the use of ExclusiveArch. PCSX2 will both compile and run on x86_64 and i686, but the code needs to use the i686 libraries. I have tried specifying these by giving a full description in BuildRequires (for example "Cg.i686") but this does not work. Is there a way to specify to compile only from i686 libraries? I have removed the optional stuff! Didn't realise it was optional ;) I have removed subversion Evince was the suggestion of the fedora packager who helped me in the forums. I guess it is for the docs. The program will run fine without the contents of %doc. I removed the CFLAGS Again, my mistake to call cmake twice I have moved the part changing permissions to %prep, I think the build places some documents in the wrong place for Fedora, so I have left the parts of the spec that move them - maybe I should write a patch instead? I will check the code and see what I can do. I have changed the desktop file install and moved the icons to the correct place - Oh; now I have just noticed the comment about the icon cache scriptlets. I will read about this now, but it will take me a few days to get around to making any changes - I will get back to you on this problem The altered spec and srpm are uploaded now, as it is a forum attachment the url is changed; the url for the srpm is http://forums.pcsx2.net/attachment.php?aid=39905 the url for the spec is: http://forums.pcsx2.net/attachment.php?aid=39904 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.