[Bug 2531] Review request: moc - Music on Console - Console audio player for Linux/UNIX

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531 --- Comment #1 from Elder Marco <eldermarco(a)gmail.com&gt; 2012-10-16 01:44:27 CEST --- Hello, Just a few comments: - You don't need to add the first line (# This file is made...). The identity of the packager is evident from the changelog entry; - It would be nice if you add one package per line in Requires/BuildRequires; - You can remove BuidRoot and Groups tags [1] - Replace %{_make} and %{_rm} with make and rm [2]. Do not use macros for simple things. You never know if/how they are defined; - You should own the directory %{_datadir}/%{name} [3]; [1] - http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [2] - http://fedoraproject.org/wiki/Packaging:Guidelines#Macros [3] - http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Own... -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.