[Bug 3102] Review Request: vdr-softhddevice - A software and GPU emulated HD output device plugin for VDR

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3102 --- Comment #7 from Alec Leamas <leamas.alec(a)gmail.com&gt; 2014-01-09 19:47:48 CET --- Just some random comments: - The macro usage is IMHO inconsistent. I would just remove %commitdate (used only once) and probably also %pname - it will not change so it's no point having a macro for it. OTOH, use the %commit macro in %Source0. - The installation part looks odd. Why are you not using 'make install DESTDIR=...', it seems that the Makefile has full support for this. Seems safer to me. - The %defattr is not needed. - There seem to be a fedora-specific configuration file(?) Does this require something like README.fedora? -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.