[Bug 2531] Review request: moc - Music on Console - Console audio player for Linux/UNIX

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531 Björn Esser <bjoern.esser(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |4 --- Comment #38 from Björn Esser <bjoern.esser(a)gmail.com&gt; 2013-06-08 13:49:04 CEST --- (In reply to comment #36) Sorry, my bad... was a bit tired yesterday... hope you don't mind... ##### Everything is fine so far. Just one thing: There is not need for explicit Requires: curl, jack-audio-connection-kit, ncurses, speex They are picked up by rpm's automagick Requires. I leave it up to you fixing this in SCM. There are some proposals/remarks as commented in review, too. ##### Package Review ============== Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. ---> all fine as discussed above. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. [x]: Package consistently uses macro is (instead of hard-coded directory names). ---> Is that `%global exec` really needed? Up to your decision... [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 112640 bytes in 8 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. ---> pre-release 2.5.0 beta1 [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. ---> you should ask upstream to update/include license-headers/info from latest GPLv2+ revision. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. ---> there could be %check, but it's quiet exhaustive. Full tests take est. >= 15 min on i7-2860QM [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: moc-2.5.0-0.8.beta1.fc20.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint moc 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- moc (rpmlib, GLIBC filtered): /sbin/ldconfig curl ffmpeg jack-audio-connection-kit libFLAC.so.8()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libavcodec.so.54()(64bit) libavcodec.so.54(LIBAVCODEC_54)(64bit) libavformat.so.54()(64bit) libavformat.so.54(LIBAVFORMAT_54)(64bit) libavutil.so.52()(64bit) libavutil.so.52(LIBAVUTIL_52)(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdb-5.3.so()(64bit) libid3tag.so.0()(64bit) libjack.so.0()(64bit) libltdl.so.7()(64bit) libm.so.6()(64bit) libmad.so.0()(64bit) libmodplug.so.1()(64bit) libncursesw.so.5()(64bit) libogg.so.0()(64bit) libpthread.so.0()(64bit) librcc.so.0()(64bit) libsamplerate.so.0()(64bit) libsamplerate.so.0(libsamplerate.so.0.0)(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libspeex.so.1()(64bit) libtimidity-0.1.so.0()(64bit) libtinfo.so.5()(64bit) libvorbis.so.0()(64bit) libvorbisfile.so.3()(64bit) libwavpack.so.1()(64bit) libz.so.1()(64bit) ncurses opus rtld(GNU_HASH) speex Provides -------- moc: libffmpeg_decoder.so()(64bit) libflac_decoder.so()(64bit) libmodplug_decoder.so()(64bit) libmp3_decoder.so()(64bit) libsndfile_decoder.so()(64bit) libspeex_decoder.so()(64bit) libtimidity_decoder.so()(64bit) libvorbis_decoder.so()(64bit) libwavpack_decoder.so()(64bit) moc moc(x86-64) Unversioned so-files -------------------- moc: /usr/lib64/moc/decoder_plugins/libffmpeg_decoder.so moc: /usr/lib64/moc/decoder_plugins/libflac_decoder.so moc: /usr/lib64/moc/decoder_plugins/libmodplug_decoder.so moc: /usr/lib64/moc/decoder_plugins/libmp3_decoder.so moc: /usr/lib64/moc/decoder_plugins/libsndfile_decoder.so moc: /usr/lib64/moc/decoder_plugins/libspeex_decoder.so moc: /usr/lib64/moc/decoder_plugins/libtimidity_decoder.so moc: /usr/lib64/moc/decoder_plugins/libvorbis_decoder.so moc: /usr/lib64/moc/decoder_plugins/libwavpack_decoder.so ---> as discussed above. Source checksums ---------------- http://ftp.daper.net/pub/soft/moc/unstable/moc-2.5.0-beta1.tar.bz2 : CHECKSUM(SHA256) this package : 076816da9c6d1e61a386a1dda5f63ee2fc84bc31e9011ef70acc1d391d4c46a6 CHECKSUM(SHA256) upstream package : 076816da9c6d1e61a386a1dda5f63ee2fc84bc31e9011ef70acc1d391d4c46a6 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -u https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531 ##### This one is APPROVED! -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.