[Bug 3102] Review Request: vdr-softhddevice - A software and GPU emulated HD output device plugin for VDR
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3102
--- Comment #14 from MartinKG <mgansser(a)alice.de> 2014-01-10 14:29:15 CET ---
(In reply to comment #10)
No blocker, but please remove also gittag, using %short_commit in
release
instead. After all, 5.%{short_commit}%{?disttag} is a perfectly sane
revision; %gittag just adds noise.
done
The fedora config file is fine just the user finds it. But generally
speaking, she will not do this since she will look in the docs for it.
Hence a specific README.fedora is probably needed which just says that
the configuration file is added. No blocker.
"works" as-is.
Is the %description outdated? The website lists (many) more
capabilitites.
Or is it just that not everything is enabled in the Fedora build?
If the list becomes too long I'd suggest removing the planned features -
they are probably less interesting as package info.
done
Please try to reorganize %prep so all charset conversions are lumped
together and done in a (more) uniform way. As of now, you keep the date
on one file - the other is plain wrong (see the rpmlint warning). I
suggest for f in ChangeLog README.txt; do (...)
done
The sed patching of Makefile in %prep seems to be a no-op. Can you
just
remove it?
done
The configuration seems somewhat messy. The Makefile looks for a
pkgconfig
file, but vdr-devel does not provide this. OTOH vdr-devel does provide
a vdr-config binary, but this is not used in the Makefile. Probably worth
reporting upstream. If you maintain vdr-devel (?), you could just add a
pkgconfig .pc file to it so things are more consistent. Or patch Makefile to
use vdr-config. No blocker, it sort of "works" as-is.
Makefile checks this with /usr/lib64/pkgconfig/vdr.pc (vdr-devel package)
You need to add %{optflags} to the build (CFLAGS=%{optflags} should
work, but must be checked.)
done
Rpmlint:
vdr-softhddevice.i686: W: file-not-utf8
/usr/share/doc/vdr-softhddevice-0.6.0/README.txt
vdr-softhddevice.i686: W: incoherent-version-in-changelog
0.6.0-5.git978fc59.fc20 ['0.6.0-5.git978fc59.fc19', '0.6.0-5.git978fc59']
corrected
Fix these (omit the disttag in the changelog revision, otherwise it
fails
depending on buildhost).
done
Spec URL:
https://www.dropbox.com/s/d6ap93hmsitv0if/vdr-softhddevice.spec
SRPM URL:
https://www.dropbox.com/s/1cj3galtebgj5e4/vdr-softhddevice-0.6.0-7.978fc5...
%changelog
* Thu Jan 09 2014 Martin Gansser <martinkg(a)fedoraproject.org> - 0.6.0-7.978fc59
- removed gittag
- updated description
- put together README and changelog file conversion in %%prep section
- removed sed patching of Makefile
- changed changelog revision
- changed build flags
rpmlint vdr-softhddevice-0.6.0-7.978fc59.fc20.x86_64.rpm
vdr-softhddevice.x86_64: W: spelling-error %description -l en_US resample -> re
sample, re-sample, res ample
vdr-softhddevice.x86_64: W: spelling-error %description -l en_US deinterlacer
-> interlace, interlard, intercede
vdr-softhddevice.x86_64: W: spelling-error %description -l en_US atmo -> atom,
ammo, at mo
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
rpmlint vdr-softhddevice-0.6.0-7.978fc59.fc20.src.rpm
vdr-softhddevice.src: W: spelling-error %description -l en_US resample -> re
sample, re-sample, res ample
vdr-softhddevice.src: W: spelling-error %description -l en_US deinterlacer ->
interlace, interlard, intercede
vdr-softhddevice.src: W: spelling-error %description -l en_US atmo -> atom,
ammo, at mo
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.