[Bug 528] Review request: mlt++ - C++ wrapper for the MLT library
http://bugzilla.rpmfusion.org/show_bug.cgi?id=528
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oget.fedora(a)gmail.com
Blocks|2 |3
Status|NEW |ASSIGNED
--- Comment #2 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-04-17 06:33:14 ---
This one is simpler. Here are my notes:
* rpmlint:
mlt++-devel.x86_64: W: no-documentation
See below.
mlt++.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmlt++.so.0.3.8
/lib64/libm.so.6
This shouldn't be hard to fix. Please report this upstream.
* Group tag for the main package should be System Environment/Libraries
* From their contents, it looks like the doc files CUSTOMISING HOWTO README
belong to the devel subpackage
* The license notes in the header of the files look weird. It is a mixture of
GPL and LGPL. Can you ask upstream to clarify this?
* I don't think you need this line
find ./ -name configure -exec chmod 755 {} \;
(You should check for such changes yourself when there is a new release.)
* From the installed header files, I can tell that mlt++-devel must require
mlt-devel = %{version}
* Requires: pkgconfig can be removed. Package does not install a .pc file.
* In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release} .
Is there a reason to have an exception here?
? Shouldn't we build and package what is inside the swig directory?
? How about the test directory? Shall we package it in the %doc of the devel
package?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.