[Bug 2140] bombono-dvd - DVD authoring program with nice and clean GUI
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2140
--- Comment #43 from Alec Leamas <leamas.alec(a)gmail.com> 2012-03-31 14:16:01 CEST
---
(In reply to comment #38)
Alright! Lets get this review going:
[-] sources match upstream: md5sum do not matche
-This is a blocking issue. Please make sure your source grab commands always
grab the right source. I compared the md5sum of the source in you provided in
the srpm and the the md5sum of the source that I grabbed with those commands.
There is something rotten with git glone
git://gitorious.org/bombono-dvd/bombono-dvd.git. Normally, git should retain
the file modification dates. However, in this case the files get the dates of
the checkout. Since this affects the md5sum two different clones will never
match.
I cannot do anything about this(?), it seems to be a gitorious bug or missing
feature. The situation resembles the svn case, where the md5sum also always
mismatch. The test done in these cases should really be diff -r IMHO.
Also, tip for this package and or later on, using
"--exclude-vcs" will ignore
all vcs files, such as ".svn" or ".git"
Thanks, will look into it! I hesitate at the moment, related to a script I use
to build spec file and sources. But I will definitely use it.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.