[Bug 284] Review request: picard-extras-freeworld - Acoustic fingerprinting for Picard tagger
http://bugzilla.rpmfusion.org/show_bug.cgi?id=284
--- Comment #3 from NicolasChauvet <kwizart(a)gmail.com> 2008-12-30 16:00:50 ---
CHANGE -extras- seems too much. some packages are using it for optionals
plugins that aresn't ship with the "-core" sources archives.
NOTE - In general, it seems easier to have foo-freeworld than to think either
it is foo-plugin-?? or foo-extras-??
OK - Mock Build succeed with Fedora 10 i386
INVESTIGATE - why <avcodec.h> is tried whereas this is deprecated? Compat
headers shouldn't be even try when <libavcodec/avcodec.h> is found. (For info
the ffmpeg header move appeared in July 2008.)
------------
#include <avcodec.h>
gcc -pthread -fno-strict-aliasing -DNDEBUG -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -D_GNU_SOURCE -fPIC -fPIC -I/usr/include/ffmpeg -c
_configtest.c -o _configtest.o
_configtest.c:1:21:
error:
avcodec.h: No such file or directory
------------
CHANGE - I tend to agree with Kevin. It is always useful to prevent timestamp
changes. (even if it is compiled - maybe a binary could have been ship with the
source!) I would add that using the correct perms also help. (-pm 0755) that
would prevent default behavior that could appear when installing.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.