[Bug 1728] Review request: xmris - Maze digging and cherry eating game
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1728
--- Comment #4 from Richard <hobbes1069(a)gmail.com> 2011-05-04 16:07:24 ---
(In reply to comment #3)
(In reply to comment #2)
> Tried again under mock. Needs "BR: groff" as well.
Thanks, I must admit I did not give it a spin in mock, I'll do a new version
with libXaw-devel and groff added to the BR-s. But before I do that I was
wondering if you had any other comments?
I didn't get a chance to actually run it last night after work. I'll try
tonight.
I'll go through the review checklist too.
> 2. The patch file names do not have %{name} on the front.
Although not a
> requirement I have several source rpms installed and that could make it
> difficult to know which patches are for what program.
Given the amount of patches I'm using a git tree to maintain them, this is how
git-format-patch names them :) Once a package is imported into CVS this
becomes a non issue since all the files then live in their own dir.
Yeah, not a big deal unless you manage multiple git packages and built with
rpmbuild...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.