[Bug 1927] Review request: linphone-freeworld - Phone anywhere in the whole world by using the Internet

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1927 Richard <hobbes1069(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069(a)gmail.com --- Comment #3 from Richard <hobbes1069(a)gmail.com&gt; 2011-10-06 19:45:28 --- Weeding though all the incorect fsf address (which needs to be reported upstream) output: usr/src/debug/linphone-3.4.3/gtk/chat.c linphone-freeworld-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/linphone-3.4.3/gtk/update.c linphone-freeworld-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/linphone-3.4.3/gtk/update.c These should probably be fixed. Reviewing the spec file: 1. Minor nit: Why the white space between several of the BuildRequires? If you're grouping them in some sort of order then I would add comments between instead of blank lines. 2. "rm -rf $RPM_BUILD_ROOT" can be removed from %install, %clean can be removed entirely, and "%defattr(-,root,root)" can be removed from %files unless your building for EL5. 3. --vendor in desktop-file-install should not be set[1] [1] http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_u... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.