[Bug 2300] Review request: freecad - A general purpose 3D CAD modeler

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2300 John Morris <john(a)zultron.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |john(a)zultron.com --- Comment #17 from John Morris <john(a)zultron.com&gt; 2012-06-26 07:51:32 CEST --- Hey fellas, looks like you're really close. I've made a few changes to the RPM, you're welcome to do what you like with them. Hope it gets you a little closer. Summary: - Filter out automatically generated Provides/Requires of private libraries (see below) - freecad.desktop not passing 'desktop-file-validate'; fixed - New patch to unbundle PyCXX (see below) - Add conditional build options for OpenCASCADE, bundled Zipios++, bundled PyCXX, bundled smesh (this really helped debugging the zipios++ problem described here: https://bugzilla.redhat.com/show_bug.cgi?id=834975 ) - Remove BuildRequires: tbb-devel and gts-devel (are these needed?) http://www.zultron.com/static/2012/06/freecad/freecad-0.12-6.fc16.src.rpm http://www.zultron.com/static/2012/06/freecad/freecad.spec http://www.zultron.com/static/2012/06/freecad/python-pycxx-6.2.4-0.fc16.s... http://www.zultron.com/static/2012/06/freecad/python-pycxx.spec If you guys think the PyCXX unbundling looks worthwhile, I would be happy to start the Fedora review process for python-pycxx. I would need a sponsor, though, since it would be my first time. I did my best to fix up the specfile to be as nice as Richard's, but he'll surely find numerous improvements I overlooked. ;) I didn't find a very nice solution to the Provides/Requires problem. The %filter_setup stuff is all in macros, evaluated before scripts run, so there's no way to automatically grab the list of plugins in the %install script and stick them in the macro. Instead, maintainers must manually update a %{plugins} macro at the top of the specfile. I did stick in some checks that will make the build bomb out if the %{plugins} list is out of date; that way maintainers don't have to be too vigilant, just occasionally annoyed. By the way, thanks again for this new FreeCAD RPM. It's simply so much better than my old one on zultron.com. The specfile is beautiful, because Richard wrote it, but also because of Richard's work to get the FreeCAD cmake configuration sane. My old RPM, which used the old FreeCAD automake stuff, redefined most of the %configure path options, created a bunch of ugly symlinks, and wrote a disgusting system-wide /etc/ld.so.conf.d config to help FreeCAD find plugins, really nauseous code. This new RPM and build system is a joy to work on. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.