[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs
http://bugzilla.rpmfusion.org/show_bug.cgi?id=124
--- Comment #6 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-11 15:48:24 ---
(In reply to comment #5)
Before submitting a new version, I would like to comment a few
things:
* I edit the pkgconfig file templates because they have the libdir harcoded.
Depending on whether we are compiling in 32 or 64 bits we have to write
/usr/lib or /usr/lib64 inside the files.
I see that you are just inserting the %{_libdir} macro evaluated. I think it is
fine then.
* I'm not quite sure that the tcl guidelines apply here. What
pgplot provides
is a driver that a allows to embed the plots in tcl applications, but only
using a C interface.
This means that a supposed tcl/pgplot application has to be linked with the
libtkpgplot.so library. Hence, the library has to be installed in %{libdir} so
that it can be found at runtime (or we have to make a link from
%{libdir}/tcl8/pgplot/libtkpgplot.so.* to %{libdir}).
Notice that pgplot doesn't provide a pkgIndex.tcl and I think that means that
pgplot can't be used from inside tcl/tk directly.
Regards
I read this paragraph on the guidelines (towards the bottom):
arch-specific packages can be generally grouped into three categories:
those that provide a shell, those that provide a fooConfig.sh file and a
shared library for linking, and those that only provide a shared library
for dlopen().
OK, you might be right (I am -kind of- ignorant when it comes to tcl/tk), but
doesn't this package belong to the third category ? And, then why are you
explicitly requiring tk? rpmbuild picks some tcl/tk dependencies by itself.
Aren't those enough? Please explain.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.