[Bug 4368] Review request: qt5-qtwebengine-freeworld - Qt5 - QtWebEngine components (freeworld version)

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4368 Rex Dieter <rdieter(a)math.unl.edu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |4 --- Comment #2 from Rex Dieter <rdieter(a)math.unl.edu&gt; --- naming: ok licensing: ok (but complicated, thoroughly vetted in related fedora reviews) macros: ok sources: not ok? from src.rpm: d682226dbb6c0188e20e12b6d63dab80 qtwebengine-opensource-src-5.7.1.tar.xz from referenced snapshots url: c90fba515fb33c091904fe2cadbb345a qtwebengine-opensource-src-5.7.1.tar.xz 1. MUST use verifiable sources, can you account for this difference? (maybe used a different snapshot?) builds/installs: ok runtime not tested (qt-5.7.1 available only for rawhide a the moment) 2. SHOULD confirm qtbase dependency %{?_qt5_version:Requires: qt5-qtbase%{?_isa} >= %{_qt5_version}} for the fedora package we currently use a tighter, %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} (but not a big deal, since this package also depends on the fedora base qt5-qtwebengine package...) 3. SHOULD consider using -debuginfo shrinking hacks on all archs (including x86_64) APPROVED please address item 1 prior to import, not treating as strict blocker since we're dealing with snapshots. Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=2 [Bug 2] Tracker: New packages awaiting review https://bugzilla.rpmfusion.org/show_bug.cgi?id=4 [Bug 4] Tracker: Accepted packages. -- You are receiving this mail because: You are on the CC list for the bug.