[Bug 775] Review request: xorg-x11-drv-psb - Intel GMA500 (Poulsbo) video driver (and associated packages)

http://bugzilla.rpmfusion.org/show_bug.cgi?id=775 --- Comment #4 from Lubomir Rintel <lkundrak(a)v3.sk&gt; 2009-08-21 08:55:58 --- (In reply to comment #3) That's not a good thing to do. This would confuse plague, which abuses the ExclusiveArch field and cause it to build packages for i386, i486, i586, i686, pentium3, pentium4, athlon and geode. For the packages built from source, you may want to do something like this instead: %if 0%{?fedora} > 11 ExclusiveArch: i686 %else %if 0%{?fedora} > 10 ExclusiveArch: i586 %else ExclusiveArch: i386 %endif Maybe something like "ExclusiveArch: %{?ix86:%{_target_cpu}}" would work too, I'm just not sure whether empty ExclusiveArch: wouldn't confuse plague on other arches somehow... (3) For the prebuilt binary packages, just hardcode ExclusiveArch to whatever was it built for. A brief look at xpsb-glx reveals that it uses SSE2 instructions, so it was probably compiled for Pentium M; the best you can do in plague is i686 I think. No worries, it's Friday already \o/ ;) Sponsored for cvsextras. (4) Please don't require akmod in xorg-x11-drv-psb.spec, require psb-kmod instead (so that binary module packages can be used for stable distributions). (5) Why do you include "Source5: 91-drm-modeset.rules" in libdrm-poulsbo.spec, install it and the delete it in %install? I have approved some of the packages, I'll move this bug report to the tracker of approved package when all packages are approved. ========================================== xorg-x11-drv-psb BEING REVIEWED (4) libdrm-poulsbo BEING REVIEWED (5) psb-firmware APPROVED psb-kmod APPROVED xpsb-glx APPROVED (3) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.