[Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
--- Comment #32 from Richard <hobbes1069(a)gmail.com> 2012-10-30 03:21:45 CET ---
> - Why do you explicitly install COPYING, and list it with the
full path? Why
> not just do "%doc %SOURCE2" in the %files section, and take advantage of
the
> automatic handling in rpm?
This doesn't work. RPM apparently expects to find %doc entries in the BUILD
directory. I ended up just copying %SOURCE2 in %prep and then using %doc
properly from there.
Yeah, if I remember correctly if you use a full path it doesn't copy the file
to %{_docdir} as it assumes it was put there for a reason, it only marks that
file as documentation in the resultant RPM.
> - Unless I'm mistaken, the directory
/usr/share/icons/hicolor and
> subdirectories are not owned by any package required by winetricks, right?
> Unless I misunderstand the rules
>
(https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin...),
> that means that winetricks should also own /usr/share/icons/hicolor and
> children.
That says directories should be owned by something in the "natural dependency
chain". winetricks brings in enough GNOME stuff to ensure that directory
exists.
Although it's not specified in the guidelines, the general practice I've
developed and seen used is to just Requires: (not BuildRequires)
hicolor-icon-theme since it owns that directory.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.