[Bug 396] Review request: paintdotnet - A mono port of the Paint.NET image editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=396
--- Comment #26 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-05-27 08:12:10 ---
(In reply to comment #25)
Thanks for the update!
> ! Remember that mono is not available on ppc64 for Fedora <
11. So if you
> want to build paintdotnet on Fedora < 11 you will need to use an
> ExcludeArch.
I have made a tentative change for ExcludeArch, I would appreciate feedback
on that as I am not particularly familiar with best practice for conditional
rpm building.
%if 0%{?fedora} < 11 || 0%{?rhel} < 5
ExcludeArch: ppc64
%endif
I don't think this will work. Suppose you are building for F-11, where %rhel is
not defined. Then you will have
%if false || true
which evaluates to true and ppc64 will get excluded. Replacing || with &&
should solve the issue.
Btw, is mono.ppc64 available now on RHEL5?
> ! Please use the %{name} macro consistently.
Can you please point out inconsistent usage?
For instance
%{_datadir}/applications/%{name}.desktop
%{_datadir}/icons/hicolor/256x256/apps/paintdotnet.png
I interpret the consistency rule as using %{name} all over the specfile or
using paintdotnet all over the specfile. Not a mixture of both.
I used to enforce this interpretation in my reviews in the past, but I realized
that it is not worth putting it as a blocker. However, I continue to warn
packagers about it which is indicated by my "!". I leave it up to you.
> ? You are supplying an external .desktop file. That's okay.
But why are you
> using "--add-category X-Red-Hat-Extra"? You can manually add this to the
> .desktop file.
It simply makes it easier for upstream to pick up this .desktop file without
Red-Hat specific things.
Okay, makes sense.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.