[Bug 2433] Review request: qmmp-plugin-pack-freeworld - A set of extra plugins for Qmmp

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2433 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks|2 |5 AssignedTo|rpmfusion-package-review@rp |j.w.r.degoede(a)gmail.com |mfusion.org | --- Comment #9 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-04-15 16:40:19 CEST --- Full review done: Good: - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: - rpmlint checks return: qmmp-plugin-pack-freeworld.x86_64: W: invalid-url URL: http://qmmp.ylsoftware.com/plugins_en.php HTTP Error 404: Not Found qmmp-plugin-pack-freeworld-debuginfo.x86_64: W: invalid-url URL: http://qmmp.ylsoftware.com/plugins_en.php HTTP Error 404: Not Found qmmp-plugin-pack-freeworld.src: W: invalid-url URL: http://qmmp.ylsoftware.com/plugins_en.php HTTP Error 404: Not Found I don't consider the url issue a blocker, so APPROVED! But please do fix the url to something which is not 404 before building. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.