[Bug 2857] Review request: xine-lib 1.2 - A multimedia engine
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2857
--- Comment #6 from Rex Dieter <rdieter(a)math.unl.edu> 2013-10-12 12:57:38 CEST ---
Initial comments:
1. MUST do verbose build, either via via --disable-silent-rules configure
switch, or use
make ... V=1
2. SHOULD document need for
./autogen.sh
in %prep
as far as I can tell, none of the current patches require this. For example,
it *does* help fix rpath issues. :)
3. patch0 SHOULD be dropped, and add BuildRequires: gettext-devel (autopoint
is provided by gettext-devel)
4. -devel MUST drop explicit
Requires: pkgconfig
this dependency is handled by rpm automatically these days
5. SHOULD drop/omit deprecated
Group:
tags.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.