[Bug 165] Review Request: cmus - Ncurses-Based Music Player

http://bugzilla.rpmfusion.org/show_bug.cgi?id=165 --- Comment #3 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2008-12-15 16:41:33 --- Just some questions for now: * You should really clean up the script. If you don't use patches than do not include them. * Why do you do ./configure [..] exampledir=%{_datadir}/%{name}/examples [..] and then move examples directory somewhere else? Just set exampledir as %{_defaultdocdir}/%{name}-%{version}/examples and declare this dir in the "files" section. * Why don't you use CONFIG_FFMPEG=y to have .wma support? * Why do you use both libmodplug and libmikmod since both are used to have .mod and .x3m support? * I wonder if libraries should be moved to different packages. Thus the final user can choose what to install based on his needs. * There is no compile output. Makefile must be patched to see it. * Missing doc files: AUTHORS -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.