[Bug 414] Review request: motion - Motion, a Video-surveilance-system
http://bugzilla.rpmfusion.org/show_bug.cgi?id=414
--- Comment #7 from Steven Moix <steven.moix(a)axianet.ch> 2009-03-15 22:57:28 ---
New SRPM and SPEC:
http://www.alphatek.info/divers/motion.spec
http://www.alphatek.info/divers/motion-3.2.11-2.fc10.src.rpm
- final provides and requires are sane: Is the hard requirement on
ffmpeg
needed?
# rpm -q --requires motion
...
libavcodec.so.51()(64bit)
libavformat.so.52()(64bit)
...
# rpm -q --whatprovides 'libavformat.so.52()(64bit)'
'libavcodec.so.51()(64bit)'
ffmpeg-libs-0.4.9-0.55.20080908.fc10.x86_64
ffmpeg-libs-0.4.9-0.55.20080908.fc10.x86_64
Unless motion makes direct calls to ffmpeg, ffplay or ffserver on the command
line, the autorequirement on ffmpeg-libs is fine.
Done, I removed the Requires completely, there is no direct call to the ffmpeg,
ffplay or ffserver binaries.
Some other things that need to be fixed:
* Comment out the sql_* directives as they are unrecognized without SQL support
compiled-in:
[0] Unknown config option "sql_log_image"
[0] Unknown config option "sql_log_snapshot"
[0] Unknown config option "sql_log_mpeg"
[0] Unknown config option "sql_log_timelapse"
[0] Unknown config option "sql_query"
Done with some sed lines in the spec
* Modify the initscript so that it checks if motion is already
running
Done, I'm not sure if it's totally correct though. It works but there is no
message displayed when you try to double-start it.
Minor issues - not strictly necessary, but please consider:
* Suppressing motion's output when runing 'service motion start', as this
will
appear each startup:
Starting motion: [0] Processing thread 0 - config file /etc/motion/motion.conf
[0] Motion 3.2.11 Started
[0] Motion going to daemon mode
Done by adding 2> /dev/null in the start() function of the init script.
* Removing "Motion, " from the summary field as it is
redundant. Also, Video
does not need a capital letter.
Done, completely changed the description.
* Replacing the distributed initscript with your own (or patching the
existing
one) to be LSB compliant (see
https://fedoraproject.org/wiki/Packaging/SysVInitScript#LSB_Header_Example)
Done, I modified the existing script and added it as Source1.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.