[Bug 19] Review request: blcr - Berkeley Lab Checkpoint/Restart for Linux
http://bugzilla.rpmfusion.org/show_bug.cgi?id=19
--- Comment #2 from Neal Becker <ndbecker2(a)gmail.com> 2008-02-03 22:11:23 ---
(In reply to comment #1)
From the kmod standpoint: The needed "Provides:
%{name}-kmod-common =
%{version}" is there, but none of the packages require the kmod with a
"Requires: %{name}-kmod >= %{version}". That's only fine if the software
works
fine without the modules, which according to your description is not the case.
I understand you don't want to deviate from upstream, but the spec looks a bit
cluttered. I don't like it to much and tend to say that it's not acceptable for
RPM Fusion in the current form.
https://nbecker.dyndns.org/RPM/blcr.spec
Other options?
BTW, if anybody wants to take care of this review: feel free to grab it. If
above mentioned issue is fixed the package is fine from the kmod/akmod
standpoint.
I have removed much of the cruft. I think all the above issues are addressed.
There is just one thing, maybe someone can help me with? For some reason, no
debuginfo package is built. I removed
%define debug_package %{nil}
I also changed 'make install-strip' to 'make install'. From the rpmbuild
stdout, I don't see any occurance of the word 'debug', and I don't see
any
'strip' or 'install -s'. Anyone have a clue about this?
Please try:
https://nbecker.dyndns.org/RPM/blcr-0.6.4-3.src.rpm
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.