[Bug 3174] Review request: xbmc-pvr-addons - XBMC PVR add-ons

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3174 --- Comment #19 from Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 2014-05-09 01:23:19 CEST --- A couple more things... Please add extra percent signs to escape the macros and silence the warnings: xbmc-pvr-addons.src:6: W: macro-in-comment %{commit} xbmc-pvr-addons.src:8: W: macro-in-comment %{commit_date} xbmc-pvr-addons.src:8: W: macro-in-comment %{short_commit} Please add "Provides: bundled(md5-plumb)", since addons/pvr.nextpvr/src/md5.cpp bundles this md5 implementation (https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries) GPLv2+", since different plugins are under different licenses (and some bits, eg cmyth, are even a combination of LGPL and GPL). For this part: # Delete useless files rm $RPM_BUILD_ROOT%{_datadir}/xbmc/addons/*/*.in What .in files is make installing? That sounds like it should be reported and fixed upstream. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.