[Bug 26] Review request: dvbcut - Clip and convert DVB transport streams to MPEG2 program streams
http://bugzilla.rpmfusion.org/show_bug.cgi?id=26
--- Comment #40 from David Timms <dtimms(a)iinet.net.au> 2009-01-01 00:13:36 ---
(In reply to comment #39)
[-] MUST: The package must be named according to the Package Naming
Guidelines.
Use an %{alphatag} beginning with the date in YYYYMMDD format
(this is OK) and followed by up to 16 (ASCII) alphanumeric characters
of your choosing (this is not OK). For example: 20081218svn. See:
That
could be read to be at 1<=charscount<=16, I guess. I had read the
guideline in conjunction with looking at another spec (ffmpeg), which doesn't
use an alphatag, there is quite a few packages in RPM Fusion that do this:
BasiliskII, SheepShaver, *madwifi, arcem, autopano-sift-C, ffmpeg,
*iscsitarget, larabie, live555, slmodem, vdrsync, x264.
[-] MUST: The License field in the package spec file must match the
actual
license.
README.icons say that icons are under LGPLv2
Source files says licences is GPLv2+
Therefore licence must be GPLv2+ and LGPLv2, See:
Would this apply ?
"7: LGPLv2.1 gives you permission to relicense the code under any version of
the GPL since GPLv2. If you can switch the LGPLed code in this case to using an
appropriate version of the GPL instead (as noted in the table), you can make
this combination. "
I'm not sure what relicensing would entail: does it mean you have to adjust
every file mentioning the LGPL 2.1 to GPL2 or greater ?
In any case, I have done what you initially suggested.
[-] MUST: The sources used to build the package must match the
upstream source,
as provided in the spec URL.
dvbcut-snapshot.sh doesn't seem to work. Maybe instructions are wrong
or not detailed. I get cannot connect to server error.
I think this is
probably just a temporary connection problem, since it works
for me at the moment.
This did lead me to review the script; I adjusted the commented out command
that nukes the internally included ffmpeg sources and patches from the svn tree
to use a find rather than rm.
[-] MUST: Each package must consistently use macros, as described in
the macros
section of Packaging Guidelines.
In the %files section use either dvbcut or %{name} not both.
Done.
SHOULD Items:
[=] SHOULD: Packages should try to preserve timestamps of original installed
files.
Timestamps are not preserved using the original makefile. This should
be patched.
Isn't the only file that is built is dvbcut executable ? It
would have the time
that the rpmbuild %build completed. A moment later %install sticks it in the
buildroot. Is that the concern you are raising ?
New spec:
http://members.iinet.net.au/~timmsy/dvbcut/dvbcut.spec
srpm:
http://members.iinet.net.au/~timmsy/dvbcut/dvbcut-0.5.4-6.20090101svn138....
Note the included sources now use the updated -snapshot script, and hence the
postrelease date is today's date. This reduces the sources size from 750kB to
180kB.
Thanks for the detailed review :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.